all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 33836@debbugs.gnu.org
Subject: [bug#33836] [PATCH] services: zabbix-front-end: Show location in messages.
Date: Wed, 26 Dec 2018 18:31:33 +0100	[thread overview]
Message-ID: <878t0cchze.fsf@gnu.org> (raw)
In-Reply-To: <20181223153633.13009-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sun, 23 Dec 2018 18:36:33 +0300")

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/services/monitoring.scm (zabbix-front-end-config): Show location in
> messages.

[...]

>  (define zabbix-front-end-config
>    (match-lambda
>      (($ <zabbix-front-end-configuration>
> -        _ db-host db-port db-name db-user db-password db-secret-file
> +        location _ db-host db-port db-name db-user db-password db-secret-file
>          zabbix-host zabbix-port)

Could you instead use ‘match-record’ here?  That way you could avoid
maching the ‘location’ field altogether.

Are there other users of ‘define-configuration’ that match raw records?

Thanks,
Ludo’.

  reply	other threads:[~2018-12-26 17:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-22 20:38 [bug#33836] [PATCH 0/2] location in define-configuration Oleg Pykhalov
2018-12-22 20:42 ` [bug#33836] [PATCH 1/2] services: configuration: Add location Oleg Pykhalov
2018-12-22 20:42   ` [bug#33836] [PATCH 2/2] services: zabbix-front-end: Show location in messages Oleg Pykhalov
2018-12-23 14:21   ` [bug#33836] [PATCH 1/2] services: configuration: Add location Oleg Pykhalov
2018-12-23 15:36     ` [bug#33836] [PATCH] services: zabbix-front-end: Show location in messages Oleg Pykhalov
2018-12-26 17:31       ` Ludovic Courtès [this message]
2018-12-23 15:40     ` [bug#33836] [PATCH 1/2] services: configuration: Add location Oleg Pykhalov
2018-12-26 17:30       ` Ludovic Courtès
2019-02-15 22:24         ` Ludovic Courtès
2019-02-28 22:39           ` [bug#33836] [PATCH 0/2] Apply suggestions Oleg Pykhalov
2019-02-28 22:40             ` [bug#33836] [PATCH 1/2] services: configuration: Add '%location' Oleg Pykhalov
2019-02-28 22:40             ` [bug#33836] [PATCH 2/2] services: zabbix-front-end: Show location in messages Oleg Pykhalov
2019-03-10 17:21             ` [bug#33836] [PATCH 0/2] Apply suggestions Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t0cchze.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=33836@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.