all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 46028-done@debbugs.gnu.org
Subject: bug#46028: [PATCH core-updates 0/2] Farewell to PYTHONPATH.
Date: Mon, 01 Feb 2021 13:35:52 -0500	[thread overview]
Message-ID: <878s87skjb.fsf_-_@gmail.com> (raw)
In-Reply-To: <878s8by8ds.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Fri,  29 Jan 2021 12:12:47 -0500")

Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Hi,
>>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>>
>>> Using PYTHONPATH as a mean to discover the Python packages had the following
>>> issues:
>>>
>>>         1. It is not versioned, so different versions of Python would clash if
>>>         installed in a shared profile.
>>>
>>>         2. It would interfere with the host Python site on foreign
>>>         distributions, sometimes preventing a a user to login their GDM
>>>         session (!).
>>>
>>>         3. It would take precedence over user installed Python packages
>>>         installed through pip.
>>>
>>>         4. It would leak into Python virtualenvs, which are supposed to create
>>>         isolated Python environments.
>>
>> I've adapted the most problematic uses of PYTHONPATH in the code base
>> (mostly (getenv "PYTHONPATH"), which would typically now return #f and
>> pushed the branch to cu/farewell-to-pythonpath (it contains ~160
>> commits, so I thought it'd be easier to review as a branch).
>
> There's now a third version of this that I pushed to the
> cu/farewell-to-pythonpath branch.  It now uses GUIX_PYTHONPATH instead
> of GUIX_PYTHONPATH_X_Y, which makes it easier to use in any package
> definition (as there's no longer a need to import the (guix build
> python-build-system) module for packages not using the Python build
> system).
>
> I'll merge it soon if nobody has an objection.

I've now pushed this to core-updates.

Closing!

Maxim




      reply	other threads:[~2021-02-01 18:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22  4:48 [bug#46028] [PATCH core-updates 0/2] Farewell to PYTHONPATH Maxim Cournoyer
2021-01-22  4:51 ` [bug#46028] [PATCH core-updates 1/2] utils: Add a version-minor procedure Maxim Cournoyer
2021-01-22  4:51   ` [bug#46028] [PATCH core-updates 2/2] gnu: python: Replace PYTHONPATH by GUIX_PYTHONPATH_X_Y Maxim Cournoyer
2021-01-22 13:18     ` [bug#46028] [PATCH core-updates v2] " Maxim Cournoyer
2021-01-25  7:08       ` Maxim Cournoyer
2021-01-29 17:12         ` [bug#46028] [PATCH core-updates 0/2] Farewell to PYTHONPATH Maxim Cournoyer
2021-02-01 18:35           ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s87skjb.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=46028-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.