all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Pierre Langlois <pierre.langlois@gmx.com>, 47707-done@debbugs.gnu.org
Subject: bug#47707: [PATCH] gnu: gpodder: Update to 3.10.18.
Date: Sun, 11 Apr 2021 15:58:45 +0100	[thread overview]
Message-ID: <878s5oyije.fsf@gmx.com> (raw)
In-Reply-To: <cb31c11cdd3aea9e60232d78687cd2b8d2b867ad.camel@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

Hi Maxime,

Maxime Devos writes:

>> +       (modify-phases %standard-phases
>> +         (add-before 'check 'fix-library-loading
>> +           (lambda _
>> +             (setenv "PYTHONPATH" (string-append (getenv "PYTHONPATH") ":."))
>> +             #t))
>
> Returning #t is not required anymore, please remove.  The warning that results if
> a phase doesn't return #t has been removed on core-updates.

Oh cool, done, going to have to get rid of the habit of adding it :-).

>
> No other comments, thanks for updating.
> Warning: I haven't tested the patch.

Thanks for the review! Pushed with
fca8ef0d765f47faed88100e3c9734cfab3768cd.

Pierre

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

      reply	other threads:[~2021-04-11 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 12:33 [bug#47707] [PATCH] gnu: gpodder: Update to 3.10.18 Pierre Langlois
2021-04-11 14:46 ` Maxime Devos
2021-04-11 14:58   ` Pierre Langlois [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s5oyije.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=47707-done@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.