From: "Ludovic Courtès" <ludo@gnu.org>
To: David Aaron Fendley <tricon@triconium.com>
Cc: 51440@debbugs.gnu.org
Subject: [bug#51440] [PATCH 00/10] Declarative static networking interface
Date: Thu, 11 Nov 2021 23:08:39 +0100 [thread overview]
Message-ID: <878rxufiqg.fsf_-_@gnu.org> (raw)
In-Reply-To: <20211103132704.GA24459@triconium.com> (David Aaron Fendley's message of "Wed, 3 Nov 2021 09:27:04 -0400")
[-- Attachment #1: Type: text/plain, Size: 1804 bytes --]
Hi David,
David Aaron Fendley <tricon@triconium.com> skribis:
> If I have:
>
> (service static-networking-service-type
> (list (static-networking
> (addresses (list (network-address
> (device "eno33559296")
> (value "10.7.99.99/24"))
> (network-address
> (device "eno16780032")
> (value "10.10.199.98/24"))))
> (routes (list (network-route
> (destination "default")
> (gateway "10.10.199.1"))
> (network-route
> (destination "192.168.0.1/32")
> (gateway "10.10.199.1"))))
> (name-servers '("10.10.199.17" "10.10.101.2")))))
>
> After reconfigure and restart of the networking service, no routes
> listed are created. Only the standard routes for each network:
Hmm right, I need to investigate this one some more. Apparently the
‘route-add’ call leads to “Network is unreachable”.
[...]
> If I then change the config to:
>
> (service static-networking-service-type
> (list (static-networking
> (addresses (list (network-address
> (device "eno33559296")
> (value "10.0.7.15/24"))
> (network-address
> (device "eno16780032")
> (value "10.10.2.15/24"))))
> (routes (list (network-route
> (destination "default")
> (gateway "10.0.2.2"))))
> (name-servers '("10.0.2.3")))))
>
>
>
> After reconfigure and restart of the networking service, routes
> specified are still not created, and the addresses and routes are
> appended:
This one is fixed by the patch below: the ‘stop’ method of the service
would not actually load the “tear-down-network” file, oops!
Thanks a lot for testing and reporting!
To be continued…
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1881 bytes --]
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 66683f153f..3123122200 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2511,7 +2511,7 @@ (define network-set-up/linux
addresses)
#$@(map (match-lambda
(($ <network-link> name type arguments)
- #~(link-add #:device #$name #$type
+ #~(link-add #$name #$type
#:type-args '#$arguments)))
links)
#$@(map (lambda (route)
@@ -2530,7 +2530,7 @@ (define network-set-up/linux
(define network-tear-down/linux
(match-lambda
(($ <static-networking> addresses links routes)
- (scheme-file "set-up-network"
+ (scheme-file "tear-down-network"
(with-extensions (list guile-netlink)
#~(begin
(use-modules (ip addr) (ip link) (ip route))
@@ -2579,10 +2579,10 @@ (define (static-networking-shepherd-service config)
(network-set-up/hurd config))))))
(stop #~(lambda _
;; Return #f is successfully stopped.
- #$(let-system (system target)
- (if (string-contains (or target system) "-linux")
- (network-tear-down/linux config)
- (network-tear-down/hurd config)))))
+ (load #$(let-system (system target)
+ (if (string-contains (or target system) "-linux")
+ (network-tear-down/linux config)
+ (network-tear-down/hurd config))))))
(respawn? #f))))))
(define (static-networking-shepherd-services networks)
next prev parent reply other threads:[~2021-11-11 22:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:59 [bug#51440] [PATCH 00/10] Declarative static networking interface Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 01/10] tests: Add 'static-networking' test Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 02/10] tests: openvswitch: Check whether ovs0 is up Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 03/10] doc: Add new "Networking Setup" node for the main setup options Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 04/10] gnu: guile-netlink: Allow cross-compilation Ludovic Courtès
2021-10-28 0:58 ` Julien Lepiller
2021-10-29 21:38 ` [bug#51440] [PATCH 00/10] Declarative static networking interface Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 05/10] services: static-networking: Use Guile-Netlink on GNU/Linux Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 06/10] services: secret-service: Turn into a Shepherd service Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 07/10] services: static-networking: Change interface to mimic netlink Ludovic Courtès
2021-10-28 1:17 ` Julien Lepiller
2021-10-29 21:43 ` [bug#51440] [PATCH 00/10] Declarative static networking interface Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 08/10] services: Define '%qemu-static-networking' Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 09/10] services: Define '%loopback-static-networking' Ludovic Courtès
2021-10-27 14:02 ` [bug#51440] [PATCH 10/10] tests: Replace uses of deprecated 'static-networking-service' Ludovic Courtès
2021-10-27 15:29 ` [bug#51440] [PATCH 00/10] Declarative static networking interface Julien Lepiller
2021-10-29 21:44 ` Ludovic Courtès
2021-11-03 13:27 ` David Aaron Fendley
2021-11-11 22:08 ` Ludovic Courtès [this message]
2021-11-14 20:52 ` Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 " Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 01/10] tests: Add 'static-networking' test Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 02/10] tests: openvswitch: Check whether ovs0 is up Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 03/10] doc: Add new "Networking Setup" node for the main setup options Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 04/10] gnu: guile-netlink: Allow cross-compilation Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 05/10] services: static-networking: Use Guile-Netlink on GNU/Linux Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 06/10] services: secret-service: Turn into a Shepherd service Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 07/10] services: static-networking: Change interface to mimic netlink Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 08/10] services: Define '%qemu-static-networking' Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 09/10] services: Define '%loopback-static-networking' Ludovic Courtès
2021-11-15 22:30 ` [bug#51440] [PATCH v2 10/10] tests: Replace uses of deprecated 'static-networking-service' Ludovic Courtès
2021-11-17 17:13 ` [bug#51440] [PATCH 00/10] Declarative static networking interface Ludovic Courtès
2021-11-17 19:36 ` Jonathan Brielmaier
2021-11-17 19:36 ` [bug#51440] Static IPv6 address is reversed! Vivien Kraus via Guix-patches via
2021-12-10 10:51 ` [bug#51440] [PATCH 00/10] Declarative static networking interface Ludovic Courtès
2021-12-11 12:56 ` Vivien Kraus via Guix-patches via
2021-12-11 21:39 ` Ludovic Courtès
2021-12-11 22:19 ` Julien Lepiller
2021-12-11 23:32 ` Vivien Kraus via Guix-patches via
2021-12-12 22:00 ` Ludovic Courtès
2021-12-12 22:26 ` Vivien Kraus via Guix-patches via
2021-12-12 23:11 ` bug#51440: " Ludovic Courtès
2021-12-13 17:29 ` [bug#51440] " Mathieu Othacehe
2021-12-14 11:17 ` Vivien Kraus via Guix-patches via
2021-12-14 15:03 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rxufiqg.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=51440@debbugs.gnu.org \
--cc=tricon@triconium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.