all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Maxime Devos <maximedevos@telenet.be>,
	54829@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: [bug#54829] [PATCH 0/2] Update Emacs to 28.1 and add socket activation
Date: Thu, 28 Apr 2022 14:15:31 +0200	[thread overview]
Message-ID: <878rrpe74s.fsf_-_@gnu.org> (raw)
In-Reply-To: <ea79ad869b1630dd0ecd9cc5d5dd04b6333e8522.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 10 Apr 2022 13:32:27 +0200")

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs)[#:phases]: Add ‘enable-elogind’.
> [inputs]: Add elogind.
> [native-inputs]: Add autoconf.

[...]

> +          (add-after 'unpack 'enable-elogind
> +            (lambda _
> +              (substitute* "configure.ac"
> +                (("libsystemd") "libelogind"))

I suggest making that substitution in ‘configure’…

>      (native-inputs
> -     (list pkg-config texinfo))
> +     (list autoconf pkg-config texinfo))

… so you don’t need this extra dependency.

Otherwise it LGTM.

Perhaps you can push to a ‘wip-emacs-28’ branch, and then ping me or
another admin on #guix so we can tell ci.guix to build it.  Once it’s
built and we don’t see regressions, we can merge in ‘master’ (should
take a day or two at most I suppose).

Thanks,
Ludo’.

PS: First time it takes more than a few hours for a new Emacs version to
    land in Guix!  :-)




  reply	other threads:[~2022-04-28 12:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09 10:29 [bug#54829] [PATCH 0/2] Update Emacs to 28.1 and add socket activation Liliana Marie Prikler
2022-04-09  8:15 ` [bug#54829] [PATCH 1/2] gnu: emacs: Update to 28.1 Liliana Marie Prikler
2022-04-10 10:21   ` Maxime Devos
2022-04-10 10:23   ` Maxime Devos
2022-04-09 10:28 ` [bug#54829] [PATCH 2/2] gnu: emacs: Add support for socket activation Liliana Marie Prikler
2022-04-10 11:23 ` [bug#54829] [PATCH v3 1/3] gnu: emacs: Update to 28.1 Liliana Marie Prikler
2022-04-10 11:23 ` [bug#54829] [PATCH v2 " Liliana Marie Prikler
2022-04-11  8:53   ` Michael Rohleder
2022-04-12  8:15   ` [bug#54829] [PATCH 0/2] Update Emacs to 28.1 and add socket activation zimoun
2022-04-12 18:19     ` Liliana Marie Prikler
2022-04-13 10:29       ` zimoun
2022-04-10 11:28 ` [bug#54829] [PATCH v2 2/3] gnu: emacs: Use new package style Liliana Marie Prikler
2022-04-10 11:28 ` [bug#54829] [PATCH v3 " Liliana Marie Prikler
2022-04-10 11:32 ` [bug#54829] [PATCH v3 3/3] gnu: emacs: Add support for socket activation Liliana Marie Prikler
2022-04-28 12:15   ` Ludovic Courtès [this message]
2022-04-28 15:06     ` [bug#54829] [PATCH 0/2] Update Emacs to 28.1 and add " Maxime Devos
2022-04-28 15:31       ` Liliana Marie Prikler
2022-04-28 20:15       ` Ludovic Courtès
2022-04-28 16:58     ` Liliana Marie Prikler
2022-04-29  3:22       ` Feng Shu
2022-04-29 18:53         ` Liliana Marie Prikler
2022-04-29 21:56           ` [bug#54829] " tumashu
2022-05-18  4:13           ` Maxim Cournoyer
2022-05-18 17:47             ` bug#54829: " Liliana Marie Prikler
2022-04-10 11:32 ` [bug#54829] [PATCH v2 3/3] gnu: emacs: Add support for " Liliana Marie Prikler
2022-04-26 21:27 ` [bug#54829] Other emacs packages Luis Henrique Gomes Higino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rrpe74s.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=54829@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=maximedevos@telenet.be \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.