From: Josselin Poiret <dev@jpoiret.xyz>
To: zimoun <zimon.toutoune@gmail.com>, kiasoc5 <kiasoc5@disroot.org>,
guix-devel@gnu.org, Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: git guix checkout automation for contributors
Date: Mon, 26 Sep 2022 22:37:22 +0200 [thread overview]
Message-ID: <878rm5c1od.fsf@jpoiret.xyz> (raw)
In-Reply-To: <878rm6csm9.fsf@gmail.com>
Hello everyone,
zimoun <zimon.toutoune@gmail.com> writes:
> Hi,
>
> On dim., 25 sept. 2022 at 21:40, kiasoc5 <kiasoc5@disroot.org> wrote:
>> Isn't there a checkout cache in ~/.cache/guix? Can guix edit be pointed
>> to the git repo in the cache as opposed to the system's?
>
> This checkout* is used by “guix time-machine” and it does not always
> point to what “guix describe” returns. Modulo this minor warning
> (easily fixable by moving HEAD to the correct commit), it appears to me
> a good idea to rely on it for easing some contributions.
It would be a good idea to reuse the cache, however I don't think that
edits should be made directly there. Maybe we could either suggest or
provide a command that would copy the git repository there to another
place.
> When running “guix time-machine” (inferiors), all the machinery
> “./bootstrap && ./configure --localstatevar=/var && make” is
> transparently done. We discussed that at the 10 Years event with
> Josselin.
Yes! Although FTR none of bootstrap, configure or make are actually run
when using time-machine, it's a totally different way of building :).
The upshot is that we could even provide a flag like `guix time-machine
--issue=NNNNN` that would provide the corresponding guix branch at
https://git.guix-patches.cbaines.net/guix-patches/, and benefit from the
built substitutes if there are. It would need some more formal URL and
discussion around this feature, but everything's in place for it to
happen.
> Therefore, we could imagine something similar for helping people to
> contribute:
>
> 1. use (test?) unmerged patches
> 2. update and/or create new patches
I think the second part would need a bit of work though, refer to Chris'
mail [1] for what would need to be done (namely, making `git send-email`
easier and refactoring the contribution guidelines).
[1] 87a66wfzeh.fsf@cbaines.net
https://yhetil.org/guix-devel/87a66wfzeh.fsf@cbaines.net
Best,
--
Josselin Poiret
next prev parent reply other threads:[~2022-09-26 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.14689.1664114844.1079.guix-devel@gnu.org>
2022-09-25 21:40 ` git guix checkout automation for contributors kiasoc5
2022-09-26 10:55 ` zimoun
2022-09-26 20:37 ` Josselin Poiret [this message]
2022-09-27 8:38 ` zimoun
2022-09-25 14:06 Danny Milosavljevic
2022-09-25 15:04 ` Danny Milosavljevic
2022-09-25 16:36 ` Maxime Devos
2022-10-01 17:18 ` Ludovic Courtès
2022-10-05 3:18 ` Maxim Cournoyer
2022-11-02 18:41 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rm5c1od.fsf@jpoiret.xyz \
--to=dev@jpoiret.xyz \
--cc=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=kiasoc5@disroot.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.