unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: guix-devel@gnu.org
Subject: Notes from discussion on Quality Assurance from the 10 Years of Guix event
Date: Sun, 18 Sep 2022 17:55:30 +0200	[thread overview]
Message-ID: <87a66wfzeh.fsf@cbaines.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]

Here are some notes I took during the discussion on patch review/quality
assurance at the 10 Years of Guix event.

Discussion:
- Find out how others review patches
  - Julian
    - Subscribe to guix-patches
    - Look at subjects
    - If not OCaml/Java/Maven, ignore email
    - If obvious issues can be seen, reply suggesting improvements
    - Run guix lint/build dependents
    - There are language/area specific things that are good to know
      about when reviewing patches

- How the process works
  - How we can improve quality of Guix, avoid breakages
  - How we can simplify the workflow for reviewers
  - Minimise the burden for submitters
    - Lengthy guidance for submitting patches
    - Changelog format
    - Sending patches by email (git send-email)
    - guix lint archive error
    - Delay in feedback for first time submitters

  - Problems
    - Already broken packages when applying updates

- How to help?

- Motivation to do more
  - Debian: How can I help tool?
- Learn how to review more patches
- Doing useful things with little time


Actions:
 - teams thing for finding out about patches, automate this somehow
 - generate a web page listing the people and teams
 - Filtered subscription to patches by team

 - Improve the qa.guix.gnu.org site
 - look at moving Mumi, QA Frontpage, ... on to Savannah
 - List infrastructure projects on a web page

 - More detailed guidance on the review process
 - Guidance for reviewers, e.g. don't ask for patch submitters to fix
   other problems
 - Split the guidance for submitting patches in to sections (bronze,
   silver, gold)
 - Give specific guidance for different tasks, so don't run lint if
   you're upgrading a package
 - Have some "trusted reviewer" status
 - Arrange focused time per month/week when people try to review patches
 - How should reviewers get patches merged when they don't have commit
   access?
 - Maybe script making contributions like updating packages

 - Make a similar tool to Debian's how can I help
   - Try to avoid suggesting updating packages with lots of dependencies

 - work out what is getting in the way of patches getting to the mailing
   list/debbugs
   - Put a warning about delays

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

             reply	other threads:[~2022-09-18 15:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 15:55 Christopher Baines [this message]
2022-10-05 14:01 ` Notes from discussion on Quality Assurance from the 10 Years of Guix event Tanguy LE CARROUR
2022-10-05 16:51   ` Christopher Baines
2022-10-09 15:58     ` Tanguy LE CARROUR
2022-10-18 16:19   ` Tanguy LE CARROUR
2022-10-19  9:57     ` zimoun
2022-10-23 15:40       ` Tanguy LE CARROUR
2022-10-24  7:34         ` zimoun
2022-10-24 11:43           ` Tanguy LE CARROUR
2022-10-23 21:33       ` kiasoc5
2022-10-19 19:31     ` Efraim Flashner
2022-10-23 15:48       ` Tanguy LE CARROUR
2022-10-24  7:44         ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a66wfzeh.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).