all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 58397@debbugs.gnu.org
Cc: "\(" <paren@disroot.org>, 58397-done@debbugs.gnu.org
Subject: [bug#58397] [PATCH 2/2] gnu: emacs-ivy-pass: Don't propagate password-store.
Date: Mon, 10 Oct 2022 18:27:09 +0200	[thread overview]
Message-ID: <878rlnve3m.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20221009165749.16619-2-paren@disroot.org> (guix-patches@gnu.org's message of "Sun, 9 Oct 2022 17:57:49 +0100")

Hello,

"( via Guix-patches" via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ivy-pass)[propagated-inputs]
>   <password-store>: Delete it.
> [synopsis, description]: Use @command when referring to pass.

Thank you. Applied with the following changes.

> -      (source
> -       (origin
> -         (method git-fetch)
> -         (uri (git-reference
> -               (url "https://github.com/ecraven/ivy-pass")
> -               (commit commit)))
> -         (file-name (git-file-name name version))
> -         (sha256
> -          (base32
> -           "18crb4zh2pjf0cmv3b913m9vfng27girjwfqc3mk7vqd1r5a49yk"))))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/ecraven/ivy-pass")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "18crb4zh2pjf0cmv3b913m9vfng27girjwfqc3mk7vqd1r5a49yk"))))

This change is not warranted, so I removed it.

>        (build-system emacs-build-system)
> -      (propagated-inputs
> -       (list emacs-ivy emacs-password-store password-store))
> +      (propagated-inputs (list emacs-ivy emacs-password-store))

I think the newline removal isn't either.

>        (home-page "https://github.com/ecraven/ivy-pass")
> -      (synopsis "Ivy interface for password store (pass)")
> -      (description "This package provides an Ivy interface for working with
> -the password store @code{pass}.")
> +      (synopsis "Ivy interface to @code{pass}")
> +      (description
> +       "This package provides an Ivy interface for working with the
> +password store (@command{pass}) in Emacs.")

I used @code here too, since you're probably referring to the project's
name.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2022-10-10 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 16:56 [bug#58397] [PATCH 0/2] gnu: emacs-password-store: Refer directly to password-store ( via Guix-patches via
2022-10-09 16:57 ` [bug#58397] [PATCH 1/2] " ( via Guix-patches via
2022-10-09 16:57   ` [bug#58397] [PATCH 2/2] gnu: emacs-ivy-pass: Don't propagate password-store ( via Guix-patches via
2022-10-10 16:27     ` Nicolas Goaziou [this message]
2022-10-10 16:12   ` bug#58397: [PATCH 1/2] gnu: emacs-password-store: Refer directly to password-store Nicolas Goaziou
2022-10-10 16:23     ` [bug#58397] " ( via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rlnve3m.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=58397-done@debbugs.gnu.org \
    --cc=58397@debbugs.gnu.org \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.