all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Csepp <raingloom@riseup.net>
Cc: 58174@debbugs.gnu.org
Subject: [bug#58174] [PATCH 1/3] gnu: Add ocaml-domain-name.
Date: Tue, 22 Nov 2022 10:01:44 +0000	[thread overview]
Message-ID: <878rk3s3vi.fsf@cbaines.net> (raw)
In-Reply-To: <875yf8mdol.fsf@riseup.net>

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]


Csepp <raingloom@riseup.net> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> [[PGP Signed Part:Undecided]]
>>
>> Thanks for the patches. I don't think there's a need for another module
>> though, and if there is, it should probably have a more general topic
>> than mirage (e.g. networking).
>>
>> So yeah, would you be able to move these packages to the ocaml module
>> and send an updated patch series?
>>
>> Thanks,
>>
>> Chris
>>
>> [[End of PGP Signed Part]]
>
> I have a lot more packages in it (40-ish), a lot of them mirage
> specific. Working in a separate file made rebasing and sorting commits
> much easier.
> But if it's a problem, I can move them to the main ocaml file, but I'd
> like to avoid it becoming a monolith like gtk.scm, if for no other
> reason than because I don't want to waste my time waiting for GUILEC to
> recompile a bunch of expression I did not touch.

I'm fine with mirage specific stuff going in a mirage module, my issue
is that these first packages are not mirage specific, so I'd like to see
the separate module be more general (e.g. about networking), or for them
to just go in the ocaml module.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2022-11-22 10:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 16:47 [bug#58174] [PATCH 1/3] gnu: Add ocaml-domain-name raingloom
2022-09-29 16:47 ` [bug#58173] [PATCH 2/3] gnu: Add ocaml-macaddr raingloom
2022-09-29 16:47 ` [bug#58172] [PATCH 3/3] gnu: Add ocaml-ipaddr raingloom
2022-11-21 13:51 ` [bug#58174] [PATCH 1/3] gnu: Add ocaml-domain-name Christopher Baines
2022-11-21 17:08   ` zimoun
2022-11-22  8:29     ` Christopher Baines
2022-11-21 17:11   ` Csepp
2022-11-22 10:01     ` Christopher Baines [this message]
2022-11-22 12:22       ` zimoun
2022-11-22 14:42         ` Julien Lepiller
2022-11-22 12:30       ` Csepp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rk3s3vi.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=58174@debbugs.gnu.org \
    --cc=raingloom@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.