From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: Sughosha <Sughosha@proton.me>
Cc: 58955-done@debbugs.gnu.org, Christopher Baines <mail@cbaines.net>
Subject: bug#58955: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
Date: Sun, 29 Jan 2023 14:56:57 +0800 [thread overview]
Message-ID: <878rhlj0au.fsf_-_@envs.net> (raw)
In-Reply-To: <LOSJ7r7IzVOyd74oZrqwpUSIN9ssFcv2s9-PPTZc8v5mL4X5H8EA09VdzLYoatR3mLf9hD3bouU_9isjwp5hCE-jP4U8pL9pB7BjCdWACUA=@proton.me> (Sughosha@proton.me's message of "Fri, 04 Nov 2022 13:29:14 +0000")
Sughosha <Sughosha@proton.me> writes:
> Hi Christopher,
>
> Thanks for reviewing the patch.
>
>> From the diff, it looks like oss is being disabled, rather than
>> unbundled. What's the reasoning behind disabling it?
> OSS is not needed since it was superseded by ALSA and it does the job.
> I disabled it because it's not at all used in Guix and also not needed
> as we have ALSA. Sorry for not being accurate in the message.
>>
>> Adding portaudio as an input seems fine I guess, but it might be good to
>> remove the portaudio files from the source (through a snippet) if there
>> are some there.
> I tried it but autoconf or automake looks for it and gives error, before
> starting building.
Pushed with adjusted commit message, thank you!
prev parent reply other threads:[~2023-01-29 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 1:28 [bug#58955] [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio Sughosha via Guix-patches via
2022-11-03 17:27 ` Christopher Baines
2022-11-04 13:29 ` Sughosha via Guix-patches via
2023-01-29 6:56 ` 宋文武 via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rhlj0au.fsf_-_@envs.net \
--to=guix-patches@gnu.org \
--cc=58955-done@debbugs.gnu.org \
--cc=Sughosha@proton.me \
--cc=iyzsong@envs.net \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.