From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 29535@debbugs.gnu.org
Subject: [bug#29535] [PATCH] gnu: Add cli-visualizer.
Date: Tue, 05 Dec 2017 13:46:15 +0100 [thread overview]
Message-ID: <877eu1cpgo.fsf@gnu.org> (raw)
In-Reply-To: <87h8t9ne67.fsf@gmail.com> (Oleg Pykhalov's message of "Sat, 02 Dec 2017 22:05:36 +0300")
Oleg Pykhalov <go.wigust@gmail.com> skribis:
>>From 54a00afb4e628019dbfe3f9b7f09a553dab3cfb9 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Sat, 2 Dec 2017 22:03:13 +0300
> Subject: [PATCH] gnu: Add cli-visualizer.
>
> * gnu/packages/audio.scm (cli-visualizer): New variable.
[...]
> + (inputs
> + `(("fftw" ,fftw)
> + ("ncurses" ,ncurses)
> + ("pulseaudio" ,pulseaudio)
> + ("which" ,which)))
Most likely ‘which’ should be in ‘native-inputs’ (it’s not referred to
at run time, is it?).
Besides, I’d encourage you to not align inputs like this, for
consistency with the rest of the code, though that’s not that big a
deal. :-)
> + (add-after 'unpack 'remove-sudo
> + (lambda _ (substitute* "install.sh" (("sudo") ""))))
> + (add-before 'install 'make-prefix
> + (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/bin"))))
> + (add-after 'install 'data
> + (lambda _ (for-each (lambda (file)
> + (install-file file "/share/doc"))
> + (list "asound_alsa.conf" "asound_alsa_with_dmix.conf"
> + "basic_colors" "blue" "config" "rainbow")))))))
Nitpick: please write the lambda’s body on a separate line, and make
sure each phase returns a Boolean:
(lambda _
(substitute* …)
#t)
> + (synopsis "CLI audio visualizer")
s/CLI/Command-line/
> + (description "@code{cli-visualizer} provides a command line audio
> +visualizer for MPD, Alsa and Pulseaudio.")
s/Alsa/ALSA/
It would be nice if you could clarify in the description what “audio
visualizer” means. Perhaps something like:
It can display fast-Fourier transforms (FFTs) of the sound being
played, as well as other graphical representations.
OK with these changes, thank you!
Ludo’.
next prev parent reply other threads:[~2017-12-05 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 19:05 [bug#29535] [PATCH] gnu: Add cli-visualizer Oleg Pykhalov
2017-12-03 7:36 ` [bug#29535] Status: " Oleg Pykhalov
2017-12-05 12:46 ` Ludovic Courtès [this message]
2017-12-11 21:09 ` bug#29535: " Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eu1cpgo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29535@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.