all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Ricardo Wurmus <rekado@elephly.net>, 31399@debbugs.gnu.org
Subject: [bug#31399] [PATCH] import: elpa: Implement recursive import.
Date: Tue, 29 May 2018 16:31:54 +0200	[thread overview]
Message-ID: <877enmzg6d.fsf@gnu.org> (raw)
In-Reply-To: <87603bc31l.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Fri, 25 May 2018 14:50:30 +0200")

Hello,

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>>
>>> I stole recursive importer from ‘cran’ and made it for ‘elpa’, the patch
>>> is attached.  I don't like it and want to share the code with ‘cran’
>>> importer, but I don't know how to do it without increasing complexity.
>>
>> Indeed.  Ricardo and I discussed this in the past and Ricardo started
>> implementing something:
>>
>>   http://lists.gnu.org/archive/html/guix-devel/2016-08/msg00381.html
>>
>> It would be great to resume work on this, especially since we have other
>> importers that would immediately benefit from it (CRAN, Go, Crates).
>>
>> The solution I proposed back then was to have importers return a SRFI-41
>> lazy stream of package definitions.
>
> The CRAN importer supports recursion and it is implemented with SRFI-41
> lazy streams and AIUI this is what this patch does for the elpa
> importer.
>
> We should move “recursive-import” to “(guix import utils)” and let it
> take the package generator procedure (e.g. “cran->guix-package”) as an
> argument.  It looks like this patch copied “recursive-import” and
> changed little more than “cran->guix-package” to “elpa->guix-package”,
> so this seems like a simple change.

Sounds like a plan.

Oleg, could you factorize what’s common between the two importers in
(guix import utils) like Ricardo suggests?

Thanks,
Ludo’.

  reply	other threads:[~2018-05-29 14:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10  8:37 [bug#31399] [PATCH] import: elpa: Implement recursive import Oleg Pykhalov
2018-05-25 12:00 ` Ludovic Courtès
2018-05-25 12:50   ` Ricardo Wurmus
2018-05-29 14:31     ` Ludovic Courtès [this message]
2018-05-30 16:35       ` Oleg Pykhalov
2018-06-01 20:40         ` Ludovic Courtès
2018-06-08 12:08           ` Oleg Pykhalov
2018-06-08 12:59             ` Ricardo Wurmus
2018-06-08 19:35               ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877enmzg6d.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31399@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.