From: "Ludovic Courtès" <ludo@gnu.org>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: 39932@debbugs.gnu.org
Subject: [bug#39932] [PATCH 1/3] gnu: python-xyz: Add python-distlib.
Date: Sun, 08 Mar 2020 21:18:12 +0100 [thread overview]
Message-ID: <877dzua9dn.fsf@gnu.org> (raw)
In-Reply-To: <20200305192204.14973-1-kuba@kadziolka.net> ("Jakub \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\= message of "Thu, 5 Mar 2020 20:22:02 +0100")
Hello,
Jakub Kądziołka <kuba@kadziolka.net> skribis:
> * gnu/packages/python-xyz.scm (python-distlib): New variable.
[...]
> + (modify-phases %standard-phases
> + (add-before 'build 'no-/bin/sh
> + (lambda _
> + (substitute* '("distlib/scripts.py" "tests/test_scripts.py")
> + (("/bin/sh") (which "sh")))))
> + (add-before 'check 'prepare-test-env
> + (lambda _
> + (setenv "HOME" "/tmp")
> + ;; NOTE: Any value works, the variable just has to be present.
> + (setenv "SKIP_ONLINE" "1"))))))
Please return #t from both phases, as is conventional.
Apart from that, all 3 patches LGTM!
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-03-08 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 19:14 [bug#39932] [PATCH 0/3] python-virtualenv: Update to 20.0.8 Jakub Kądziołka
2020-03-05 19:22 ` [bug#39932] [PATCH 1/3] gnu: python-xyz: Add python-distlib Jakub Kądziołka
2020-03-05 19:22 ` [bug#39932] [PATCH 2/3] gnu: python-xyz: Add python-filelock Jakub Kądziołka
2020-03-05 19:22 ` [bug#39932] [PATCH 3/3] gnu: python-virtualenv: Update to 20.0.8 Jakub Kądziołka
2020-03-08 20:18 ` Ludovic Courtès [this message]
2020-03-08 23:22 ` bug#39932: [PATCH 1/3] gnu: python-xyz: Add python-distlib Jakub Kądziołka
2020-03-05 20:29 ` [bug#39932] Addendum: python-virtualenv: Update to 20.0.8 Jakub Kądziołka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dzua9dn.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39932@debbugs.gnu.org \
--cc=kuba@kadziolka.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.