From: Brice Waegeneire <brice@waegenei.re>
To: Ryan Prior <rprior@protonmail.com>
Cc: 41679@debbugs.gnu.org
Subject: [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4
Date: Sun, 07 Jun 2020 23:18:21 +0200 [thread overview]
Message-ID: <877dwilgma.fsf@waegenei.re> (raw)
In-Reply-To: <20200602234337.11487-1-rprior@protonmail.com> (Ryan Prior's message of "Tue, 02 Jun 2020 23:43:48 +0000")
Hello Ryan,
Thank you for the patch!
Ryan Prior <rprior@protonmail.com> writes:
> * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4
> ---
> gnu/packages/vpn.scm | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
The update is fine, but that package is missing several dependencies, at
least: python-jinja2, coreutils and iproute. Try running it in a pure
environment and it will crash “guix environment --pure --container
--ad-hoc protonvpn-cli -- protonvpn -h”.
Searching the source for “subprocess.run” I find call to other binaries
which aren't listed as dependencies. Could you wrap the “protonvpn”
binary with the “PATH” of all the binaries it uses to avoid propagating
a whole lot of packages. Probably only “python-jinja2” should be
propagated.
- Brice
next prev parent reply other threads:[~2020-06-07 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 23:43 [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4 Ryan Prior via Guix-patches via
2020-06-07 21:18 ` Brice Waegeneire [this message]
2020-09-09 21:08 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dwilgma.fsf@waegenei.re \
--to=brice@waegenei.re \
--cc=41679@debbugs.gnu.org \
--cc=rprior@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.