From: Mark H Weaver <mhw@netris.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>, 51559@debbugs.gnu.org
Cc: maxim.cournoyer@gmail.com
Subject: bug#51559: [PATCH v2] gnu: webkit: Disable SSE2 when not on x86_64.
Date: Sat, 06 Nov 2021 04:55:36 -0400 [thread overview]
Message-ID: <877ddlu0gs.fsf@netris.org> (raw)
In-Reply-To: <5a2e4473e11fef78539f75a86f4cda9c105c44be.camel@gmail.com>
Hi Liliana,
I have one more comment:
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> @@ -241,7 +241,7 @@ (define-public webkitgtk
> (build-system cmake-build-system)
> (outputs '("out" "doc"))
> (arguments
> - '(#:tests? #f ; no tests
> + `(#:tests? #f ; no tests
> #:build-type "Release" ; turn off debugging symbols to save space
> #:configure-flags (list
> "-DPORT=GTK"
You'll need to remove this hunk in order to apply this to 'master',
since I've already made the change above in commit
4fd12fb00d595b6f6a5d5cc734863f4c4bc5f46c.
> @@ -295,6 +295,13 @@ (define-public webkitgtk
> (("libWPEBackend-fdo-([\\.0-9]+)\\.so" all version)
> (string-append wpebackend-fdo "/lib/" all)))
> #t)))
> + ,@(if (string-prefix? "x68_64" (or (%current-target-system)
> + (%current-system)))
> + '()
> + '((add-after 'unpack 'disable-sse2
> + (lambda _
> + (substitute* "Source/cmake/DetectSSE2.cmake"
> + (("CHECK_FOR_SSE2\\(\\)") ""))))))
As a general recommendation, it would be preferable to add the phase
only on the systems that need it (32-bit x86), instead of adding it on
every system except x86_64. The code above will force rebuilds on every
system other than x86_64, whereas if the test was done as I suggested,
rebuilds would only happen on 32-bit x86 systems.
However, in this particular case it hardly matters, since our libsoup
package currently fails to build on any system that's not x86-based.
Thanks,
Mark
--
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>.
next prev parent reply other threads:[~2021-11-06 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 21:02 bug#51559: Webkit fails to build Liliana Marie Prikler
2021-11-02 3:14 ` Maxim Cournoyer
2021-11-02 5:43 ` Mark H Weaver
2021-11-04 18:23 ` Maxim Cournoyer
2021-11-04 19:59 ` Liliana Marie Prikler
2021-11-04 21:58 ` Mark H Weaver
2021-11-05 4:21 ` Maxim Cournoyer
2021-11-05 5:17 ` Liliana Marie Prikler
2021-11-05 20:06 ` bug#51559: [PATCH] gnu: webkitgtk: Disable SSE2 when not on x86_64 Liliana Marie Prikler
2021-11-05 20:15 ` Maxime Devos
2021-11-05 22:19 ` Liliana Marie Prikler
2021-11-05 22:38 ` Maxime Devos
2021-11-06 8:00 ` Mark H Weaver
2021-11-06 8:21 ` bug#51559: [PATCH v2] gnu: webkit: " Liliana Marie Prikler
2021-11-06 8:44 ` Mark H Weaver
2021-11-06 8:55 ` Mark H Weaver [this message]
2021-11-06 9:42 ` Liliana Marie Prikler
2021-11-06 18:06 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ddlu0gs.fsf@netris.org \
--to=mhw@netris.org \
--cc=51559@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.