all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Timotej Lazar <timotej.lazar@araneo.si>
Cc: 51573-done@debbugs.gnu.org
Subject: bug#51573: [PATCH] gnu: virtualization: Add qemu-guest-agent service.
Date: Fri, 12 Nov 2021 23:41:29 +0100	[thread overview]
Message-ID: <877ddddmjq.fsf@gnu.org> (raw)
In-Reply-To: <20211102190629.14471-1-timotej.lazar@araneo.si> (Timotej Lazar's message of "Tue, 2 Nov 2021 20:06:32 +0100")

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi,

Timotej Lazar <timotej.lazar@araneo.si> skribis:

> * gnu/services/virtualization.scm (<qemu-guest-agent-configuration>): New
> record.
> (qemu-guest-agent-shepherd-service): New procedure.
> (qemu-guest-agent-service-type): New variable.
> * doc/guix.texi (Virtualization Services): Document it.

Nice.  Do you think we could have a simple test under (gnu tests
virtualization) for this?

Applied with the cosmetic changes below.

Thanks!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1140 bytes --]

diff --git a/doc/guix.texi b/doc/guix.texi
index c0dfb2e5e2..7e54b5f75e 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -30060,14 +30060,14 @@ Return the name of @var{platform}---a string such as @code{"arm"}.
 @end deffn
 
 
-@subsubheading QEMU guest agent
+@subsubheading QEMU Guest Agent
 
 @cindex emulation
 
 The QEMU guest agent provides control over the emulated system to the
 host.  The @code{qemu-guest-agent} service runs the agent on Guix
 guests.  To control the agent from the host, open a socket by invoking
-@code{qemu} with the following arguments:
+QEMU with the following arguments:
 
 @example
 qemu-system-x86_64 \
@@ -30098,11 +30098,11 @@ Configuration for the @code{qemu-guest-agent} service.
 
 @table @asis
 @item @code{qemu} (default: @code{qemu-minimal})
-The qemu package to use.
+The QEMU package to use.
 
 @item @code{device} (default: @code{""})
-Path to device or socket the agent uses to communicate with the host.
-If empty, QEMU uses a default path.
+File name of the device or socket the agent uses to communicate with the
+host.  If empty, QEMU uses a default file name.
 @end table
 @end deftp
 

      reply	other threads:[~2021-11-12 22:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 19:06 [bug#51573] [PATCH] gnu: virtualization: Add qemu-guest-agent service Timotej Lazar
2021-11-12 22:41 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ddddmjq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=51573-done@debbugs.gnu.org \
    --cc=timotej.lazar@araneo.si \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.