all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Niklas Eklund <niklas.eklund@posteo.net>
Cc: 54089-done@debbugs.gnu.org
Subject: bug#54089: [PATCH] gnu: Add emacs-highlight-doxygen
Date: Tue, 22 Feb 2022 11:35:48 +0100	[thread overview]
Message-ID: <877d9n429n.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87fsoc9mi0.fsf@posteo.net> (Niklas Eklund's message of "Mon, 21 Feb 2022 17:07:35 +0000")

Hello,

Niklas Eklund <niklas.eklund@posteo.net> writes:

> here is a patch adding the highlight-doxygen package for Emacs.

Thank you. I applied your patch with the changes explained below.

> +(define-public emacs-highlight-doxygen
> +  ;; Upstream does not tag releases.  Commit below matches version bump.
> +  (let ((commit "eec4874e2e89d4eb39091aad89a67dff8f8ec84c")
> +        (revision "0"))
> +    (package
> +      (name "emacs-highlight-doxygen")
> +      (version (git-version "0.0.2" revision commit))

Since commit matches version bump, you don't need GIT-VERSION at all.
I removed REVISION binding, and wrote:

  (version "0.0.2")

> +      (description
> +       "Advanced highlighting package for Doxygen comments.

This is not a complete sentence. I wrote

  This package highlights Doxygen comments.

Regards,
-- 
Nicolas Goaziou




      reply	other threads:[~2022-02-22 10:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 17:07 [bug#54089] [PATCH] gnu: Add emacs-highlight-doxygen Niklas Eklund
2022-02-22 10:35 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d9n429n.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=54089-done@debbugs.gnu.org \
    --cc=niklas.eklund@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.