From: "Ludovic Courtès" <ludo@gnu.org>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 54723@debbugs.gnu.org
Subject: [bug#54723] [PATCH] Check URI when verifying narinfo validity.
Date: Tue, 05 Apr 2022 19:08:12 +0200 [thread overview]
Message-ID: <877d83lapv.fsf@gnu.org> (raw)
In-Reply-To: <87a6czbzvh.fsf@kitej> (Guillaume Le Vaillant's message of "Tue, 05 Apr 2022 09:58:18 +0000")
Hi,
Guillaume Le Vaillant <glv@posteo.net> skribis:
> When trying to upgrade a machine using a substitute server on the same
> LAN, I get this crash a lot:
>
> # guix system reconfigure --substitute-urls="http://192.168.0.22:8080 https://ci.guix.gnu.org" /etc/guix/config.scm
> substitute: mise à jour des substituts depuis « http://192.168.0.22:8080 »... 100.0 %
[...]
> It looks like the 'narinfo-uri' field is an empty list instead of a list
> of URIs. Is that supposed to be possible?
I don’t think so. Could you grab a narinfo and share it?
wget -qO - http://192.168.0.22:8080/HASH.narinfo
where HASH is the hash part of a store item.
What could happen though is a situation where ‘guix publish’ only offers
a compression method not supported by the client. In that case,
‘narinfo-best-uri’ throws a match-error because ‘choices’ is the empty
list. We should fix that.
> Does the the attached patch adding a check for the validity of
> this field in the 'valid-narinfo?' function make sense?
Maybe, but I’d like to make sure we understand the issue.
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-04-05 17:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 9:58 [bug#54723] [PATCH] Check URI when verifying narinfo validity Guillaume Le Vaillant
2022-04-05 17:08 ` Ludovic Courtès [this message]
2022-04-05 17:51 ` Guillaume Le Vaillant
2022-04-09 20:32 ` Ludovic Courtès
2022-04-09 21:06 ` Guillaume Le Vaillant
2022-04-11 13:31 ` Guillaume Le Vaillant
2022-04-12 7:47 ` Ludovic Courtès
2022-04-12 8:54 ` Guillaume Le Vaillant
2022-04-14 12:18 ` Guillaume Le Vaillant
2022-04-18 19:39 ` Ludovic Courtès
2022-04-20 14:10 ` Guillaume Le Vaillant
2022-04-29 16:20 ` Ludovic Courtès
2022-04-29 21:16 ` bug#54723: " Ludovic Courtès
2022-04-30 12:12 ` Guillaume Le Vaillant
2022-04-30 12:15 ` Mathieu Othacehe
2022-05-01 13:12 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d83lapv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=54723@debbugs.gnu.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.