From: "Ludovic Courtès" <ludo@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 54796@debbugs.gnu.org
Subject: [bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang
Date: Fri, 29 Apr 2022 15:06:16 +0200 [thread overview]
Message-ID: <877d7882ev.fsf_-_@gnu.org> (raw)
In-Reply-To: <ff7998dc0ee622ecc26ba278495691dfcd62b42a.1649616716.git.h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Sun, 10 Apr 2022 20:57:00 +0200")
Hi,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
> * guix/build-system/rebar3.scm, guix/build/rebar3-build-system.scm: New files.
> * Makefile.am (MODULES): Add them.
Please mention the guix.texi changes here.
> +@defvr {Scheme Variable} rebar3-build-system
> +This variable is exported by @code{(guix build-system rebar3)}. It
> +implements a build procedure around @code{rebar3}.
Please provide a bit more context, like: “[…] around
@uref{http://example.org,rebar3}, a build system for programs written in
the Erlang language.”
> +source. If this file exists, it will be unpacked, too. This eases
> +handling of package hosted by @i{hex.pm}.
Rather: “hosted at @uref{https://hex.pm/}, the Erlang package
repository.”
> + (lambda (*)
> + (for-each
> + (lambda (dirname)
> + (let ((src-dir (string-append lib-dir "/" * "/" dirname))
> + (dst-dir (string-append pkg-dir "/" dirname)))
> + (when (file-exists? src-dir)
> + (copy-recursively src-dir dst-dir #:follow-symlinks? #t))
> + (false-if-exception
> + (delete-file (string-append dst-dir "/.gitignore")))))
> + '("ebin" "include" "priv")))
“ebin” and “priv” are non-standard directory names. It would be ideal
to avoid them, unless this is a hard requirement for Erlang/rebar3?
Otherwise LGTM!
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-04-29 13:07 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 17:01 [bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 01/22] import: Add hex.pm importer Hartmut Goebel
2022-04-09 11:52 ` Maxime Devos
2022-04-09 16:31 ` Hartmut Goebel
2022-04-09 11:53 ` Maxime Devos
2022-04-09 11:55 ` Maxime Devos
2022-04-09 16:50 ` Hartmut Goebel
2022-04-09 11:56 ` Maxime Devos
2022-04-09 11:58 ` Maxime Devos
2022-04-09 16:01 ` Hartmut Goebel
2022-04-09 11:59 ` Maxime Devos
2022-04-10 11:22 ` Hartmut Goebel
2022-04-09 12:07 ` Maxime Devos
2022-04-10 10:36 ` Hartmut Goebel
2022-04-10 12:26 ` Maxime Devos
2022-04-08 17:03 ` [bug#54796] [PATCH v3 02/22] gnu: Add erlang-cf Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 03/22] gnu: Add erlang-certifi Hartmut Goebel
2022-04-09 11:39 ` Maxime Devos
2022-04-10 10:27 ` Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 04/22] gnu: Add erlang-erlware-commons Hartmut Goebel
2022-04-09 10:58 ` Maxime Devos
2022-04-09 15:33 ` Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 05/22] gnu: Add erlang-cth-readable Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 06/22] gnu: Add erlang-bbmustache Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 07/22] gnu: Add erlang-getopt Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 08/22] gnu: Add erlang-eunit-formatters Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 09/22] gnu: Add erlang-providers Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 10/22] gnu: Add erlang-parse-trans Hartmut Goebel
2022-04-09 11:41 ` Maxime Devos
2022-04-09 15:19 ` Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 11/22] gnu: Add erlang-hex-core Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 12/22] gnu: Add erlang-ssl-verify-fun Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 13/22] gnu: Add erlang-relx Hartmut Goebel
2022-04-09 11:43 ` Maxime Devos
2022-04-09 15:32 ` Hartmut Goebel
2022-04-09 11:45 ` Maxime Devos
2022-04-09 15:18 ` Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 14/22] gnu: Add erlang-edown Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 15/22] gnu: Add erlang-jsone Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 16/22] gnu: Add erlang-proper Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 17/22] gnu: Add erlang-covertool Hartmut Goebel
2022-04-09 11:48 ` Maxime Devos
2022-04-09 15:40 ` Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 18/22] gnu: Add rebar3 Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 19/22] gnu: Add rebar3-raw-deps Hartmut Goebel
2022-04-09 11:49 ` Maxime Devos
2022-04-09 15:50 ` Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 20/22] gnu: Add rebar3-git-vsn Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 21/22] gnu: Add rebar3-proper Hartmut Goebel
2022-04-08 17:03 ` [bug#54796] [PATCH v3 22/22] build-system: Add 'rebar3-build-system' Hartmut Goebel
2022-04-09 13:16 ` Maxime Devos
2022-04-09 16:04 ` Hartmut Goebel
2022-04-09 20:56 ` Maxime Devos
2022-04-10 18:49 ` Hartmut Goebel
2022-04-09 13:19 ` Maxime Devos
2022-04-09 16:28 ` Hartmut Goebel
2022-04-09 17:57 ` Maxime Devos
2022-04-10 18:47 ` Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Hartmut Goebel
2022-04-10 18:56 ` [bug#54796] [PATCH v4 01/22] import: Add hex.pm importer Hartmut Goebel
2022-04-29 13:13 ` [bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Ludovic Courtès
2022-05-05 12:40 ` Hartmut Goebel
2022-05-05 20:48 ` Ludovic Courtès
2022-05-05 21:06 ` Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 02/22] build-system: Add 'rebar3-build-system' Hartmut Goebel
2022-04-29 13:06 ` Ludovic Courtès [this message]
2022-05-05 12:46 ` [bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 03/22] gnu: Add erlang-cf Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 04/22] gnu: Add erlang-certifi Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 05/22] gnu: Add erlang-erlware-commons Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 06/22] gnu: Add erlang-cth-readable Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 07/22] gnu: Add erlang-bbmustache Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 08/22] gnu: Add erlang-getopt Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 09/22] gnu: Add erlang-eunit-formatters Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 10/22] gnu: Add erlang-providers Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 11/22] gnu: Add erlang-parse-trans Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 12/22] gnu: Add erlang-hex-core Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 13/22] gnu: Add erlang-ssl-verify-fun Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 14/22] gnu: Add erlang-relx Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 15/22] gnu: Add erlang-edown Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 16/22] gnu: Add erlang-jsone Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 17/22] gnu: Add erlang-proper Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 18/22] gnu: Add erlang-covertool Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 19/22] gnu: Add rebar3 Hartmut Goebel
2022-04-29 13:16 ` [bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Ludovic Courtès
2022-05-06 14:58 ` Hartmut Goebel
2022-05-09 8:25 ` Ludovic Courtès
2022-05-09 10:15 ` Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 20/22] gnu: Add rebar3-raw-deps Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 21/22] gnu: Add rebar3-git-vsn Hartmut Goebel
2022-04-10 18:57 ` [bug#54796] [PATCH v4 22/22] gnu: Add rebar3-proper Hartmut Goebel
2022-04-11 12:04 ` [bug#54796] [PATCH v4 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Maxime Devos
2022-05-05 12:56 ` Hartmut Goebel
2022-04-29 13:18 ` [bug#54796] [PATCH v3 " Ludovic Courtès
2022-04-29 14:33 ` Maxime Devos
2022-06-14 21:29 ` Ludovic Courtès
2022-06-15 9:20 ` bug#54796: [PATCH v4 " Hartmut Goebel
[not found] ` <1a53c4c0-3516-e337-2e51-ff45ee44cd8d@crazy-compilers.com>
2022-06-17 15:25 ` [bug#54796] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d7882ev.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54796@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.