From: Remco van 't Veer <remco@remworks.net>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55891@debbugs.gnu.org
Subject: [bug#55891] [PATCH] gnu: Add iec16022
Date: Fri, 10 Jun 2022 19:39:51 +0200 [thread overview]
Message-ID: <877d5opgd4.fsf@remworks.net> (raw)
In-Reply-To: <2dfe4787038a3c9b6fe21982aea621c4447eca75.camel@telenet.be>
2022/06/10 17:55, Maxime Devos:
> Remco van 't Veer schreef op vr 10-06-2022 om 17:04 [+0200]:
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/rdoeffinger/iec16022")
>> + (commit "c9a9fd926fd1e6cca9782fe3f8c2bab66010ca51")))
>> + (file-name (git-file-name name version))
>> + (sha256
>
> Contains a bug: on line
>
> https://github.com/rdoeffinger/iec16022/blob/c9a9fd926fd1e6cca9782fe3f8c2bab66010ca51/image.c#L284
>
> , it allocates a buffer, which can fail (by returning NULL).
> It then passes the possibly NULL buffer to compress2.
> Also, it writes files without checking for errors
> (e.g. EIO, ENOSPC or EDQUOT).
Good catch! I'll need to brush up on my C skills to fix these.
Meanwhile I'd like to ship including bugs, WDYT?
next prev parent reply other threads:[~2022-06-10 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 15:04 [bug#55891] [PATCH] gnu: Add iec16022 Remco van 't Veer
2022-06-10 15:42 ` Maxime Devos
2022-06-10 17:36 ` Remco van 't Veer
2022-06-10 15:45 ` Maxime Devos
2022-06-10 17:37 ` Remco van 't Veer
2022-06-10 15:47 ` Maxime Devos
2022-06-10 17:38 ` Remco van 't Veer
2022-06-10 15:55 ` Maxime Devos
2022-06-10 17:39 ` Remco van 't Veer [this message]
2022-06-10 21:47 ` Maxime Devos
2022-06-11 7:09 ` Remco van 't Veer
2022-06-25 14:53 ` Remco van 't Veer
2022-07-01 6:58 ` Remco van 't Veer
2022-07-30 23:48 ` Maxime Devos
2022-08-14 7:57 ` Remco van 't Veer
2022-06-10 17:35 ` [bug#55891] [PATCH v2] " Remco van 't Veer
2022-06-10 17:45 ` [bug#55891] [PATCH v3] " Remco van 't Veer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d5opgd4.fsf@remworks.net \
--to=remco@remworks.net \
--cc=55891@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.