From: "Ludovic Courtès" <ludo@gnu.org>
To: 61749-done@debbugs.gnu.org
Cc: 61201-done@debbugs.gnu.org
Subject: bug#61201: bug#61749: [PATCH] ui: 'display-hint' quotes extra arguments for Texinfo.
Date: Mon, 27 Feb 2023 23:55:16 +0100 [thread overview]
Message-ID: <877cw2g1m3.fsf_-_@gnu.org> (raw)
In-Reply-To: <20230224104004.19319-1-ludo@gnu.org> ("Ludovic Courtès"'s message of "Fri, 24 Feb 2023 11:40:04 +0100")
Ludovic Courtès <ludo@gnu.org> skribis:
> Fixes <https://issues.guix.gnu.org/61201>.
>
> Previously, common practice was to splice arbitrary strings (user names,
> file names, etc.) into Texinfo snippets passed to 'display-hint'. This
> is unsafe in the general case because at signs and braces need to be
> escaped to produced valid Texinfo. This commit addresses that.
>
> * guix/ui.scm (texinfo-quote): New procedure.
> (display-hint): When ARGUMENTS is non-empty, pass it to 'texinfo-quote'
> and call 'format'.
> (report-unbound-variable-error, check-module-matches-file)
> (display-collision-resolution-hint, run-guix-command): Remove explicit
> 'format' call; pass 'format' arguments as extra arguments to 'display-hint'.
> * gnu/services/monitoring.scm (zabbix-front-end-config): Likewise.
> * guix/scripts.scm (warn-about-disk-space): Likewise.
> * guix/scripts/build.scm (%standard-cross-build-options)
> (%standard-native-build-options): Likewise.
> * guix/scripts/describe.scm (display-checkout-info): Likewise.
> * guix/scripts/environment.scm (suggest-command-name): Likewise.
> * guix/scripts/home.scm (process-command): Likewise.
> * guix/scripts/home/edit.scm (service-type-not-found): Likewise.
> * guix/scripts/import.scm (guix-import): Likewise.
> * guix/scripts/package.scm (display-search-path-hint): Likewise.
> * guix/scripts/pull.scm (build-and-install): Likewise.
> * guix/scripts/shell.scm (auto-detect-manifest): Likewise.
> * guix/scripts/system.scm (check-file-system-availability): Likewise.
> (guix-system): Likewise.
> * guix/scripts/system/edit.scm (service-type-not-found): Likewise.
> * guix/status.scm (print-build-event): Likewise.
Pushed as 43c36c5c9f7a31649eb059fd16ed82bde20da3fc.
Ludo’.
next prev parent reply other threads:[~2023-02-27 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 17:05 bug#61201: Installation hint crashes when user names contain at sign Ludovic Courtès
2023-02-24 10:28 ` Ludovic Courtès
2023-02-24 10:40 ` [bug#61749] [PATCH] ui: 'display-hint' quotes extra arguments for Texinfo Ludovic Courtès
2023-02-27 22:55 ` Ludovic Courtès [this message]
2023-02-24 11:18 ` bug#61201: Installation hint crashes when user names contain at sign Csepp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cw2g1m3.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=61201-done@debbugs.gnu.org \
--cc=61749-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.