From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: rg@raghavgururajan.name, 67058@debbugs.gnu.org
Subject: [bug#67058] [PATCH gnome-team 1/4] gnu: gtk: Update to 4.12.3.
Date: Sun, 03 Dec 2023 12:24:54 -0500 [thread overview]
Message-ID: <877clv2o7t.fsf@gmail.com> (raw)
In-Reply-To: <a7e831a556accc2f937bf8d7f54977037b128f81.1699663262.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 11 Nov 2023 01:19:20 +0100")
Hi,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/gtk.scm (gtk): Update to 4.12.3.
> [source]: Remove snippet.
> [arguments]<#:configure-flags>: Add “--no-suite=headless”.
> <#:phases>: Also patch text-color tests in gsk/nodeparser.
>
> Change-Id: Iedabfd12ae4f60f02ea21f427b85aeb6b17d03d6
> ---
> gnu/packages/gtk.scm | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index 21a12689b7..6a0f5e0773 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -1119,7 +1119,7 @@ (define-public gtk+
> (define-public gtk
> (package
> (name "gtk")
> - (version "4.10.3")
> + (version "4.12.3")
> (source
> (origin
> (method url-fetch)
> @@ -1127,11 +1127,10 @@ (define-public gtk
> (version-major+minor version) "/"
> name "-" version ".tar.xz"))
> (sha256
> - (base32 "1aff06l9v40j16s4s0qvdbj8cs54qxnh41d7w2v7wdwyswd48ia5"))
> + (base32 "128ahzsj016vz8brd8kplhfkxg2q7wy7kndibx2qfr68yrif530l"))
> (patches
> (search-patches "gtk4-respect-GUIX_GTK4_PATH.patch"))
> - (modules '((guix build utils)))
> - (snippet #~(begin (delete-file-recursively "subprojects/gi-docgen")))))
> + (modules '((guix build utils)))))
If we don't need the snippet, we don't need the 'modules' field either.
> (build-system meson-build-system)
> (outputs '("out" "bin" "doc"))
> (arguments
> @@ -1157,6 +1156,7 @@ (define-public gtk
> "--suite=gtk"
> "--no-suite=failing"
> "--no-suite=flaky"
> + "--no-suite=headless" ; requires mutter…
Instead of the '...', maybe explicit that 'XXX: Requires mutter, which
transitively requires this package.' on a standalone comment.
> "--no-suite=gsk-compare-broadway")
> #:phases
> #~(modify-phases %standard-phases
> @@ -1179,6 +1179,9 @@ (define-public gtk
> (substitute* "meson.build"
> (("gtk_update_icon_cache: true")
> "gtk_update_icon_cache: false"))
> + (substitute* (find-files "testsuite/gsk/nodeparser/"
> + "^text-color.*\\.node$")
> + (("Noto Sans") "DejaVu Sans"))
> ;; Disable failing tests.
> (substitute* (find-files "testsuite" "meson.build")
> (("[ \t]*'empty-text.node',") "")
Otherwise,
Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-12-03 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 0:41 [bug#67058] [PATCH gnome-team 0/4] Upate libadwaita to 1.4.0 Liliana Marie Prikler
2023-11-11 0:19 ` [bug#67058] [PATCH gnome-team 1/4] gnu: gtk: Update to 4.12.3 Liliana Marie Prikler
2023-12-03 17:24 ` Maxim Cournoyer [this message]
2023-11-11 0:37 ` [bug#67058] [PATCH gnome-team 2/4] gnu: libxmlb: Update to 0.3.14 Liliana Marie Prikler
2023-11-11 0:38 ` [bug#67058] [PATCH gnome-team 3/4] gnu: appstream: Update to 0.16.4 Liliana Marie Prikler
2023-11-11 0:39 ` [bug#67058] [PATCH gnome-team 4/4] gnu: libadwaita: Update to 1.4.0 Liliana Marie Prikler
2023-11-19 8:52 ` bug#67058: " Liliana Marie Prikler
2023-11-18 8:21 ` [bug#67058] [PATCH gnome-team 0/4] Upate libadwaita " Vivien Kraus via Guix-patches via
2023-11-18 8:25 ` Vivien Kraus via Guix-patches via
2023-12-03 17:26 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877clv2o7t.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=67058@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.