From: Ricardo Wurmus <rekado@elephly.net>
To: pkill9@runbox.com
Cc: 34576@debbugs.gnu.org
Subject: [bug#34576] Calibre: Add icon and desktop file to Calibre
Date: Tue, 19 Feb 2019 22:26:35 +0100 [thread overview]
Message-ID: <875ztfv59w.fsf@elephly.net> (raw)
In-Reply-To: <E1gwA67-0001RN-Er@rmmprod05.runbox>
Hi pkill9,
> + (add-after 'install 'install-icon
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out")))
> + (install-file "imgsrc/calibre.svg"
> + (string-append out
> + "/share/icons/hicolor/scalable/apps")))
> + #t))
You can do without “let*” here.
> + (add-after 'install-icon 'install-desktop-file
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (mkdir-p (string-append out "/share/applications"))
> + (with-output-to-file
> + (string-append out "/share/applications/calibre.desktop")
> + (lambda _
> + (format #t
> + "[Desktop Entry]~@
> + Name=Calibre~@
> + Comment=E-book organiser and reader~@
> + Exec=~a/bin/calibre~@
> + TryExec=~@*~a/bin/calibre~@
> + Icon=calibre~@
> + Categories=Office~@
> + Type=Application~%"
> + out)))
> + #t)))
Does upstream not provide a desktop file? I’d rather see this submitted
to upstream. Have you contacted the developers about this?
Secondly, the indentation is odd. I’d write it like this:
(format #t "\
[Desktop Entry]~@
Name=…
Comment=…
…
Type=Application~%" out)
--
Ricardo
next prev parent reply other threads:[~2019-02-19 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 18:26 [bug#34576] Calibre: Add icon and desktop file to Calibre pkill9
2019-02-19 21:26 ` Ricardo Wurmus [this message]
2019-02-20 4:30 ` pkill9
2019-02-20 5:00 ` Brett Gilio
2019-02-20 5:06 ` pkill9
2019-02-20 14:08 ` Tobias Geerinckx-Rice
2019-02-20 14:25 ` Tobias Geerinckx-Rice
2020-10-01 3:18 ` bug#34576: " Michael Rohleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ztfv59w.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34576@debbugs.gnu.org \
--cc=pkill9@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.