From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Fix installer restart.
Date: Wed, 12 Feb 2020 11:02:37 +0100 [thread overview]
Message-ID: <875zgc5dj6.fsf@gmail.com> (raw)
In-Reply-To: <87tv3xyw9y.fsf@gnu.org>
Hey,
> Did you make sure that:
>
> make check-system TESTS=installed-os
>
> still passes?
Yup, still working :)
In the meantime, while testing those patches, I noticed that:
* If you edit the final operating-system configuration with a syntax
error, start the install, then come back to the final page, your changes
are lost. But I'm not sure we can do much about it.
* If you open a TTY4 during "guix init" is running on TTY1, then the
command fails, the cow-store umount will fail because the bash started
in TTY4 will keep the overlay busy. This is a corner-case but it will
happen. Maybe I should check for all processed using the store overlay
and kill them before umounting?
> I’d recommend using ‘match’ rather than ‘case’, because ‘case’ silently
> returns *unspecified* when it fails to match the value.
Sure.
> PS: I’m still looking at the installer tests we discussed before FOSDEM,
> but life got in the way so progress is slow!
Hehe, same for all of us :)
Anyway, I'll push soon, thanks for the fast review!
Mathieu
next prev parent reply other threads:[~2020-02-12 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 13:58 Fix installer restart Mathieu Othacehe
2020-02-10 14:38 ` bug#39217: " Mathieu Othacehe
2020-02-10 14:38 ` bug#38447: " Mathieu Othacehe
2020-02-10 14:38 ` Mathieu Othacehe
2020-02-12 10:04 ` bug#39217: " Mathieu Othacehe
2020-02-11 15:32 ` Ludovic Courtès
2020-02-12 10:02 ` Mathieu Othacehe [this message]
2020-02-24 16:46 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zgc5dj6.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.