From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41182@debbugs.gnu.org, Mathieu Othacehe <m.othacehe@gmail.com>
Subject: bug#41182: Profile hooks ignore system and target
Date: Wed, 13 May 2020 11:45:55 +0200 [thread overview]
Message-ID: <875zd0malo.fsf@gnu.org> (raw)
In-Reply-To: <87k11idvkz.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 11 May 2020 23:13:00 +0200")
Ludovic Courtès writes:
Hello!
> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> Actually all the profile hooks refer to the native derivation.
>
> I’ve looked at it and this problem is surprisingly tricky to address.
Thank you so much for looking into this!
> I’ve tried to address it in an API-compatible way, which meant setting
> the ‘%current-system’ and ‘%current-target-system’ parameters around the
> hook calls, but that is ugly, hard to get right (dynamic binding and
> monadic code really don’t go together well :-/), and actually raises
> another issue (‘mapm/accumulate-builds’ appears to ignore the initial
> dynamic bindings for these two parameters). Hacky patch attached to
> illustrate.
>
> So I’m very much tempted to instead require each hook to take ‘system’
> and ‘#:target’ arguments and pass them to ‘gexp->derivation’. It’ll
> break the API, in case someone out there has custom profile hooks
> (unlikely given that it’s not really documented), but I’d say that’s OK.
>
> Thoughts?
I'm all for breaking the API if that gets us further. How about doing
that on the wip-hurd-vm branch, complete building the vm-image with
services and when we have found this (and possible next steps) are
useful fixes, commit to core-updates?
It would be useful to get substitutes for such a change, though --
testing this took all night.
Other than that I can offer my observations trying to build a kind of
minimal Hurd system using
fb120a69a8 services: hurd: Use activation-service, hurd-etc-service.
both
./pre-inst-env guix system build --target=i586-pc-gnu gnu/system/examples/bare-hurd.tmpl
./pre-inst-env guix system vm-image --target=i586-pc-gnu gnu/system/examples/bare-hurd.tmpl
still want to build a native Hurd (in my case for x86_64).
So, I tried applying what your patch seems to be suggesting:
--8<---------------cut here---------------start------------->8---
diff --git a/guix/store.scm b/guix/store.scm
index 92158bd658..b27ad0fab3 100644
--- a/guix/store.scm
+++ b/guix/store.scm
@@ -1900,8 +1900,8 @@ coalesce them into a single call."
(lambda (obj)
(run-with-store store
(mproc obj)
- ;; #:system (%current-system)
- ;; #:target (%current-target-system)
+ #:system (%current-system)
+ #:target (%current-target-system)
))
lst)
store)))
--8<---------------cut here---------------end--------------->8---
and with that "system build" succeeds (after a while) but "system vm-image" says
guix system: error: gnu/packages/glib.scm:404:2: gobject-introspection@1.62.0: build system `meson' does not support cross builds
This could be mostly harmless...still building a full (non-tiny/minimal)
qemu or grub maybe?
Greetings
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
next prev parent reply other threads:[~2020-05-13 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 20:38 bug#41182: Profile hooks ignore system and target Ludovic Courtès
2020-05-11 21:13 ` Ludovic Courtès
2020-05-12 8:35 ` Mathieu Othacehe
2020-05-13 9:45 ` Jan Nieuwenhuizen [this message]
2020-05-13 10:37 ` Mathieu Othacehe
2020-05-14 12:24 ` Ludovic Courtès
2020-05-14 15:23 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zd0malo.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=41182@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.