all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Tim Johann <t1m@phrogstar.de>
Cc: 65313@debbugs.gnu.org
Subject: [bug#65313] [PATCH 0/1] gnu: Add erlang-lfe.
Date: Wed, 06 Sep 2023 13:21:23 -0400	[thread overview]
Message-ID: <875y4n5ib0.fsf@gmail.com> (raw)
In-Reply-To: <87tts7i633.fsf@phrogstar.de> (Tim Johann's message of "Wed, 06 Sep 2023 17:53:42 +0200")

Hi Tim,

Tim Johann <t1m@phrogstar.de> writes:

> Hi Maxim,
>
> Thanks for the review.  I learned a lot.

Happy to read it!

> Is there more documentation on the #:modules specification?  I would
> like to know if there is a variable containing the modules added to
> the builder file when not specifying #:modules in the arguments?  Or
> do I need to repeat them there, as I have done so far:
> #:modules '((ice-9 ftw)
>             (srfi srfi-26)
>             (guix build gnu-build-system)
>             (guix build utils))
>
> The (guix build _) modules are the ones that are present when I don't
> use the #:modules argument.  ftw is for 'scandir' and srfi-26 - as you
> suggested - for 'cut'

Your approach is the correct one.  You have to look at the
guix/build/*.scm files to see what are their default #:modules, and
combine that value with the ones you want to add.  For
#:imported-modules (which is for external scheme modules to be made
available in the environment), there are sometimes public variables that
can be used.

To make it more convenient, an improvement could be to either export
public variables for the base modules for each build system, or we could
go even farther and change the #:modules semantic so that it'd extend
rather than override what the build systems uses by default.

I hope that helps,

-- 
Thanks,
Maxim




  reply	other threads:[~2023-09-06 17:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 15:23 [bug#65313] [PATCH 0/1] gnu: Add erlang-lfe Tim Johann
2023-08-15 15:27 ` [bug#65313] [PATCH 1/1] * gnu/packages/erlang.scm (erlang-lfe): New variable Tim Johann
2023-09-05 13:41   ` [bug#65313] [PATCH 0/1] gnu: Add erlang-lfe Maxim Cournoyer
2023-09-06 15:53     ` Tim Johann
2023-09-06 17:21       ` Maxim Cournoyer [this message]
2023-09-06 20:57 ` [bug#65313] [PATCH v2] * gnu/packages/erlang.scm (erlang-lfe): New variable Tim Johann
2023-09-07  2:32   ` bug#65313: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y4n5ib0.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=65313@debbugs.gnu.org \
    --cc=t1m@phrogstar.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.