From: Marius Bakke <mbakke@fastmail.com>
To: Vagrant Cascadian <vagrant@debian.org>, 31958@debbugs.gnu.org
Subject: [bug#31958] [PATCH] gnu: Add python-pyblake2.
Date: Mon, 25 Jun 2018 21:52:30 +0200 [thread overview]
Message-ID: <874lhqej9d.fsf@fastmail.com> (raw)
In-Reply-To: <87o9g0ne4s.fsf@aikidev.net>
[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]
Vagrant Cascadian <vagrant@debian.org> writes:
> Add new package definition for python-pyblake2, needed to upgrade
> python-trezor to recent versions.
Thanks! Some comments:
[...]
> * gnu/packages/libusb.scm (python-pyblake2): New variable.
> ---
> gnu/packages/python.scm | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
There is a mismatch between the commit message and the code here :-)
Though I think this is better suited in 'python-crypto.scm'. WDYT?
[...]
> + (home-page "https://github.com/dchest/pyblake2")
> + (synopsis
> + "BLAKE2 hash function extension module")
Superfluous line break.
> + (description
> + "BLAKE2 hash function extension module")
Can you try to expand on this a little?
> + (license license:cc0)))
According to COPYING, this software is actually "octuple-licensed":
* CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
* Unlicense — http://unlicense.org/
* WTFPL Version 2 - http://www.wtfpl.net/
* Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
* OpenSSL License - https://www.openssl.org/source/license.html
* MIT License - https://opensource.org/licenses/MIT
* The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
* ISC License - https://opensource.org/licenses/ISC
Can you add each of these, along with an explaning comment?
Thanks in advance!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-06-25 19:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 20:06 [bug#31958] [PATCH] gnu: Add python-pyblake2 Vagrant Cascadian
2018-06-25 19:52 ` Marius Bakke [this message]
2018-06-25 21:07 ` Vagrant Cascadian
2018-06-25 21:20 ` Marius Bakke
2018-06-26 4:37 ` Vagrant Cascadian
2018-06-26 21:53 ` bug#31957: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lhqej9d.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=31958@debbugs.gnu.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.