Re: [PATCH 2/2] Support publishing evaluation events

[Christopher Baines <mail@cbaines.net>]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]


Clément Lassieur <clement@lassieur.org> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> * src/cuirass/base.scm (process-specs): Record the creation of new
>> evaluations as events.
>> * src/cuirass/database.scm (db-set-evaluation-done): Record when evaluations
>> finish as an event.
>> * src/cuirass/http.scm (url-handler): Add a new /api/evaluation-events page.
>> ---
>>  src/cuirass/base.scm     | 5 +++++
>>  src/cuirass/database.scm | 6 +++++-
>>  src/cuirass/http.scm     | 9 +++++++++
>>  3 files changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm
>> index e7c2597..471a15e 100644
>> --- a/src/cuirass/base.scm
>> +++ b/src/cuirass/base.scm
>> @@ -770,6 +770,11 @@ started)."
>>               (checkouts (fetch-inputs spec))
>>               (eval-id (db-add-evaluation name checkouts)))
>>          (when eval-id
>> +          (db-add-event 'evaluation
>> +                        (time-second (current-time time-utc))
>> +                        `((#:evaluation    . ,eval-id)
>> +                          (#:specification . ,name)
>> +                          (#:in_progress   . #t)))
>
> Same comment as with the other patch: I think this could go to
> database.scm, so that everything is done at the same level.

Right, I'll have a look at moving this.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]