From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41560@debbugs.gnu.org
Subject: [bug#41560] [PATCH 1/8] bootloader: Add 'disk-image-installer'.
Date: Fri, 29 May 2020 09:17:08 +0200 [thread overview]
Message-ID: <874krzyzuz.fsf@gnu.org> (raw)
In-Reply-To: <87mu5r91xa.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 28 May 2020 23:37:05 +0200")
Hey Ludo!
Thanks for the review :)
>> + (disk-image-installer bootloader-disk-image-installer
>> + (default #f))
>
> My only concern here is that we’re making an interface that’s only
> implemented by one bootloader, and I fear bitrot of the other
> bootloaders longer term. I guess we’ll see, this concern shouldn’t
> block progress.
I plan to implement it for extlinux and u-boot soon, so we should be
fine.
> Very smart. s/Grub/GRUB/ everywhere please. :-)
Yes, thank you :)
>
>> +(define (root-partition-index image)
>> + "Return the index of the root partition of the given IMAGE."
>> + (1+ (srfi-1:list-index identity
>> + (map root-partition? (image-partitions image)))))
>
> Isn’t it just (list-index root-partition (image-partitions image))?
Of course!
Mathieu
next prev parent reply other threads:[~2020-05-29 7:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:22 [bug#41560] [PATCH 0/8] image: Add MBR based boot support Mathieu Othacehe
2020-05-27 7:24 ` [bug#41560] [PATCH 1/8] bootloader: Add 'disk-image-installer' Mathieu Othacehe
2020-05-27 7:24 ` [bug#41560] [PATCH 2/8] bootloader: grub: Do not run grub-install when creating a disk-image Mathieu Othacehe
2020-05-28 21:40 ` Ludovic Courtès
2020-05-27 7:24 ` [bug#41560] [PATCH 3/8] bootloader: grub: Use inheritance to define grub-minimal-bootloader Mathieu Othacehe
2020-05-27 7:24 ` [bug#41560] [PATCH 4/8] image: Add bootloader installation support Mathieu Othacehe
2020-05-27 7:24 ` [bug#41560] [PATCH 5/8] system: image: Correct genimage configuration file indentation Mathieu Othacehe
2020-05-27 7:24 ` [bug#41560] [PATCH 6/8] image: Use grub-efi to install the EFI bootloader Mathieu Othacehe
2020-05-28 21:44 ` Ludovic Courtès
2020-05-29 7:25 ` Mathieu Othacehe
2020-05-27 7:24 ` [bug#41560] [PATCH 7/8] system: image: Fix image-with-os Mathieu Othacehe
2020-05-27 7:24 ` [bug#41560] [PATCH 8/8] image: Do not use VM to create disk-images Mathieu Othacehe
2020-05-28 21:47 ` Ludovic Courtès
2020-05-29 7:27 ` bug#41560: " Mathieu Othacehe
2020-05-29 8:45 ` [bug#41560] " Jan Nieuwenhuizen
2020-05-28 21:37 ` [bug#41560] [PATCH 1/8] bootloader: Add 'disk-image-installer' Ludovic Courtès
2020-05-29 7:17 ` Mathieu Othacehe [this message]
2020-05-27 8:09 ` [bug#41560] [PATCH 0/8] image: Add MBR based boot support Jan Nieuwenhuizen
2020-05-28 21:32 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874krzyzuz.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=41560@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.