all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Morgan.J.Smith@outlook.com
Cc: 42183@debbugs.gnu.org
Subject: [bug#42183] [PATCH] gnu: Add emacs-literate-calc-mode.
Date: Tue, 07 Jul 2020 14:37:00 +0200	[thread overview]
Message-ID: <874kqj7b83.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <DM5PR1001MB21054DCA8D09F60A9001AAB1C56B0@DM5PR1001MB2105.namprd10.prod.outlook.com> (Morgan J. Smith's message of "Fri, 3 Jul 2020 22:15:24 -0400")

Hello,

Morgan.J.Smith@outlook.com writes:

> * gnu/packages/emacs-xyz.scm (emacs-literate-calc-mode): New variable.

Thank you.

> +   (version "20200703.723")

Even though there is no actual release, the version, as specified in the
".el" file, is "0.1". So you need to bind a `version' and a `revision',
and add a comment about it at the top of the package.

> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (string-append "https://melpa.org/packages/literate-calc-mode-"
> +                         version ".el"))

We don't use source from MELPA. Please use `git-fetch' instead.

> +     (sha256
> +      (base32
> +       "1ck5ha12jrs6sfhhf3yaydji49bzakrk59agspg5xynxv22aka1v"))))

Please move the hash on the same line as `base32'.

> +   (build-system emacs-build-system)
> +   (propagated-inputs
> +    `(("emacs-s" ,emacs-s)))
> +   (home-page "https://github.com/sulami/literate-calc-mode.el")
> +   (synopsis "Literate programming for Emacs calc")

-> for Emacs Calc

> +   (description "Displays inline results for calculations, supports
> +variables and updates as you type (if you want).  Also works in your
> +favourite markup mode.")

The description should contain complete sentences, e.g. 

  This library displays inline results... and supports...

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2020-07-07 12:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04  2:15 [bug#42183] [PATCH] gnu: Add emacs-literate-calc-mode Morgan.J.Smith
2020-07-07 12:37 ` Nicolas Goaziou [this message]
2020-07-11  2:08 ` Morgan.J.Smith
2020-07-14  9:10   ` bug#42183: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kqj7b83.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=42183@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.