From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 46725@debbugs.gnu.org, Christopher Baines <mail@cbaines.net>
Subject: [bug#46725] [PATCH] gnu: guile-lib: Fix cross compilation.
Date: Mon, 08 Mar 2021 15:22:11 +0100 [thread overview]
Message-ID: <874khld8to.fsf@gnu.org> (raw)
In-Reply-To: <87zgzjoy7y.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Thu, 04 Mar 2021 08:16:49 -0500")
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi!
>>
>> Christopher Baines <mail@cbaines.net> skribis:
>>
>>> These changes were sent upstream as
>>> https://lists.gnu.org/archive/html/guile-devel/2021-02/msg00004.html
>>>
>>> Without this change, the .go files are built for the host architecture, rather
>>> than the target. I noticed this when cross building the
>>> guix-build-coordinator (for which guile-lib is an input) to the Hurd.
>>>
>>> * gnu/packages/guile-xyz.scm (guile-lib)[arguments]: Add
>>> 'patch-for-cross-compilation phase.
>>> [native-inputs]: Add autoconf, automake and gettext.
>>> (guile2.0-lib): Adjust to use alist-replace.
>>> (guile2.2-lib): Adjust to use alist-replace.
>>
>> [...]
>>
>>> + (substitute* "configure.ac"
>>> + (("GUILE_FLAGS")
>>> + "GUILE_FLAGS
>>> +if test \"$cross_compiling\" != no; then
>>> + GUILE_TARGET=\"--target=$host_alias\"
>>> + AC_SUBST([GUILE_TARGET])
>>> +fi
>>
>> You could even set ‘GUILE_TARGET’ unconditionally.
>
> It seems a conditional is needed, because info
> '(autoconf)Canonicalizing' says:
>
> The variables ‘build_alias’, ‘host_alias’, and ‘target_alias’ are
> always exactly the arguments of ‘--build’, ‘--host’, and ‘--target’; in
> particular, they are left empty if the user did not use them, even if
> the corresponding ‘AC_CANONICAL’ macro was run.
>
> I.e. without the condition '--target=' could be passed to guild, which
> probably wouldn't work.
Ah true. In Guile-{Gcrypt,zlib,…}, ‘--target’ is passed conditionally.
Apologies for the confusion!
> So it seems that nowadays the build, host, and target would take default
> values as guessed by config.guess, and that the earlier section of the
> manual should be updated?
Dunno; but in hindsight, what Chris did seemed right.
Thanks,
Ludo’.
next prev parent reply other threads:[~2021-03-08 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 20:07 [bug#46725] [PATCH] gnu: guile-lib: Fix cross compilation Christopher Baines
2021-02-24 7:58 ` Leo Prikler
2021-02-24 8:45 ` Christopher Baines
2021-02-24 8:37 ` Christopher Baines
2021-03-02 19:20 ` Ludovic Courtès
2021-03-04 13:16 ` Maxim Cournoyer
2021-03-08 14:22 ` Ludovic Courtès [this message]
2021-03-08 22:11 ` bug#46725: " Christopher Baines
2021-03-11 21:01 ` [bug#46725] " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874khld8to.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=46725@debbugs.gnu.org \
--cc=mail@cbaines.net \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.