From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 48826@debbugs.gnu.org
Subject: [bug#48826] [PATCH] scripts: substitute: Cache connection when looking for narinfos.
Date: Sat, 05 Jun 2021 22:21:45 +0200 [thread overview]
Message-ID: <874kecnjty.fsf@gnu.org> (raw)
In-Reply-To: <20210604070223.10680-1-othacehe@gnu.org> (Mathieu Othacehe's message of "Fri, 4 Jun 2021 09:02:23 +0200")
Hi Mathieu,
Mathieu Othacehe <othacehe@gnu.org> skribis:
> The process-substitution procedure is opening two distinct connections. The
> first one when looking for narinfo by calling lookup-narinfo and the other one
> when fetching nar files.
>
> Cache the connection when looking for narinfos so that process-substitution
> only opens one connection.
>
> * guix/scripts/substitute.scm (lookup-narinfo): Cache connection by using
> open-connection-for-uri/cached.
Good catch, LGTM!
Thanks,
Ludo’.
next prev parent reply other threads:[~2021-06-05 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 7:02 [bug#48826] [PATCH] scripts: substitute: Cache connection when looking for narinfos Mathieu Othacehe
2021-06-05 20:21 ` Ludovic Courtès [this message]
2021-06-06 16:56 ` bug#48826: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kecnjty.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=48826@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.