all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: kiasoc5@tutanota.com, guix-devel@gnu.org
Subject: Hardened toolchain
Date: Mon, 21 Mar 2022 14:34:49 +0100	[thread overview]
Message-ID: <874k3r8m4m.fsf@gmail.com> (raw)

Hi,

> I posted an initial message on help-guix about compiling a custom
> hardened gcc, but guix-devel is a better list to continue the
> discussion. I wanted to revisit compiling Guix packages with a
> hardened toolchain since many other distros do this to improve the
> security of their packages.

On help-guix, you mean this [1], right?

1: <https://yhetil.org/guix/MtzBL4o--3-2@tutanota.com/>


> Previous emails only mentioned passing hardening options to CFLAGS and
> LDFLAGS. Another important step is to compile features into GCC and
> binutils.  Specifically:

> * gcc can be compiled with `--enable-default-ssp --enable-default-pie`
> to enforce ssp and pic

You wrote [1]:

--8<---------------cut here---------------start------------->8---
(define-public gcc
  (package
    (inherit gcc)
    (arguments
     (substitute-keyword-arguments (package-arguments gcc)
     ((#:configure-flags flags
       `(append (list "--enable-default-ssp" "--enable-default-pie")
            ,flags)))))))
--8<---------------cut here---------------end--------------->8---

and from my understanding, it can lead to name clash because the symbol
'gcc' (define-public gcc) and the symbol 'gcc' (inherit gcc) are the
same but does not refer to the same thing.

Instead, let define as gcc-hardened or whatever else than 'gcc'.  Note
that it could be better to define a procedure taking a GCC package and
returning it with "hardened" options.  Untested,

--8<---------------cut here---------------start------------->8---
(define (make-gcc-hardened gcc)
  (package
    (inherit gcc)
    (arguments
     (substitute-keyword-arguments (package-arguments gcc)
     ((#:configure-flags flags
       `(append (list "--enable-default-ssp" "--enable-default-pie")
            ,flags)))))))

(define-public gcc-hardened
  (make-gcc-hardened gcc))
--8<---------------cut here---------------end--------------->8---

This way, it becomes easy to also get GCC@7 using such options.


> * binutils can be compiled with `--enable-relro --enable-pic` to
> enforce relro and pic

Yes.  Indeed, you need to adapt various tools from "gcc-toolchain" with
these hardened options.


> I'm not a toolchain expert by any means, but I think this is a good
> first step in improving Guix package security.

Once you have a new hardened gcc-toolchain, then you can use a package
transformation (with-c-toolchain) and recompile all the graph using this
new hardened gcc-toolchain for the packages you are interested in.

Include such and provide binary substitutes is another question. :-)
(maintenance burden, etc.)


Hope that helps

Cheers,
simon


             reply	other threads:[~2022-03-21 13:36 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 13:34 zimoun [this message]
     [not found] ` <Mymdzxm--3-2@tutanota.com>
2022-03-22 19:06   ` Hardened toolchain zimoun
2022-03-22 20:02     ` kiasoc5--- via Development of GNU Guix and the GNU System distribution.
2022-03-25 19:39       ` kiasoc5--- via Development of GNU Guix and the GNU System distribution.
2022-03-25 22:54         ` zimoun
2022-03-26 19:33           ` kiasoc5--- via Development of GNU Guix and the GNU System distribution.
2022-03-26 22:02             ` kiasoc5--- via Development of GNU Guix and the GNU System distribution.
2022-03-27 20:06             ` zimoun
2022-03-27 20:22 ` Maxime Devos
2022-03-28  3:17   ` Maxim Cournoyer
2022-03-28  7:35     ` zimoun
2022-03-29  0:02     ` kiasoc5--- via Development of GNU Guix and the GNU System distribution.
2022-03-29 10:15     ` Ludovic Courtès
2022-04-14 18:59       ` kiasoc5--- via Development of GNU Guix and the GNU System distribution.
2022-04-15 15:18       ` jbranso
2022-04-15 16:04         ` Zhu Zihao
2022-04-15 16:34           ` raingloom
2022-04-26 11:07             ` Katherine Cox-Buday
2022-04-28 17:36               ` Aurora
2022-04-28 17:41                 ` Katherine Cox-Buday
2022-04-28 19:53                   ` Aurora
2022-04-28 17:50                 ` Vagrant Cascadian
2022-04-28 19:54                   ` Aurora
2022-04-29 10:31       ` zimoun
2022-04-29 15:51         ` kiasoc5--- via Development of GNU Guix and the GNU System distribution.
2022-05-02 14:55         ` Katherine Cox-Buday
2022-05-02 16:25         ` Maxime Devos
2022-05-02 17:41           ` zimoun
2022-05-02 21:10             ` Maxime Devos
  -- strict thread matches above, loose matches on Subject: below --
2022-04-15 20:36 Nathan Dehnel
2022-04-16  3:51 ` raingloom
2022-03-21  4:31 kiasoc5--- via Development of GNU Guix and the GNU System distribution.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k3r8m4m.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=kiasoc5@tutanota.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.