From: "Ludovic Courtès" <ludo@gnu.org>
To: antlers <autumnalantlers@gmail.com>
Cc: 54846@debbugs.gnu.org
Subject: [bug#54846] [PATCH] gnu: linux: Escape the values of string-type kconfig options
Date: Thu, 28 Apr 2022 14:16:41 +0200 [thread overview]
Message-ID: <874k2de72u.fsf_-_@gnu.org> (raw)
In-Reply-To: <8735iic77o.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 12 Apr 2022 23:39:07 +0200")
Hi antlers,
Did you have a chance to look into it?
TIA,
Ludo’.
Ludovic Courtès <ludo@gnu.org> skribis:
> Hi,
>
> antlers <autumnalantlers@gmail.com> skribis:
>
>> * gnu/packages/linux.scm (config->string): add escape-string
>>
>> Handles characters within the set
>> (char-set-intersection char-set:ascii char-set:printing), removing
>> those which are known to be unsupported.
>
> [...]
>
>> (define (config->string options)
>> + (define (escape-string str)
>> + "Returns STR with the escapes necessary to be read as a string-type
>> + option's value. Handles characters within the set (char-set-intersection
>> + char-set:ascii char-set:printing), removing those which are known to be
>> + unsupported."
>
> Nitpick: You can turn the docstring into a comment since the docstring
> wouldn’t be accessible anyway.
>
>> + (fold (match-lambda* (((match? fmt) str)
>> + (transform-string str match?
>> + (cut format #f fmt <>))))
>
> Please avoid tabs.
>
> ‘transform-string’ is from (texinfo string-utils), which is not imported
> here. IMO, we’d rather avoid depending on this module since it’s really
> designed for the Texinfo machinery.
>
>> + str
>> + `((#\# "") ; No known way to escape # characters.
>> + (#\$ "$~a")
>> + ("\"\\'`" "\\~a")
>> + (";:()#" "\\\\~a")
>> + ("|" "\\\\\\~a")
>> + ;; No support for tabs, newlines, etc.
>> + (,(char-set->string (ucs-range->char-set 9 14)) ""))))
>
> I wonder if this should be implemented in terms of ‘string-fold’
> instead:
>
> (string-concatenate-reverse
> (string-fold (lambda (chr result)
> (match chr
> (#\# (cons "" result))
> ;; …
> (_ (cons (string chr) result))))
> '()
> str))
>
> Thoughts?
>
> Thanks,
> Ludo’.
next prev parent reply other threads:[~2022-04-28 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 2:24 [bug#54846] [PATCH] gnu: linux: Escape the values of string-type kconfig options antlers
2022-04-11 5:08 ` [bug#54713] " Elijah Harding
2022-04-12 21:39 ` [bug#54846] " Ludovic Courtès
2022-04-28 12:16 ` Ludovic Courtès [this message]
2022-04-28 20:18 ` Antlers
2022-05-08 4:48 ` antlers
2022-05-17 15:54 ` bug#54846: " Antlers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k2de72u.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54846@debbugs.gnu.org \
--cc=autumnalantlers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.