[bug#65034] [PATCH 0/3] gnu: go-google-golang-org-protobuf: Update to 1.31.0.

[Hilton Chain via Guix-patches via <guix-patches@gnu.org>]

Hi Maxim,

On Tue, 05 Sep 2023 21:49:18 +0800,
Maxim Cournoyer wrote:
>
[...]
> >      (arguments
> >       (list #:import-path "google.golang.org/protobuf"
> > -           #:tests? #f ; source-only package
> > -           #:phases #~(modify-phases %standard-phases
> > -                        ;; source-only package
> > -                        (delete 'build))))
> > -    (propagated-inputs (list go-github-com-google-go-cmp-cmp
> > -                             go-github-com-golang-protobuf-proto))
> > +           #:phases
> > +           #~(let ((go-packages '("proto"
> > +                                  "encoding/protojson"
> > +                                  "encoding/prototext"
> > +                                  "encoding/protowire"
> > +                                  "reflect/protoreflect"
> > +                                  "reflect/protoregistry"
> > +                                  "reflect/protodesc"
> > +                                  "reflect/protopath"
> > +                                  "reflect/protorange"
> > +                                  "testing/protocmp"
> > +                                  "testing/protopack"
> > +                                  "testing/prototest"
> > +                                  "types/dynamicpb"
> > +                                  "types/known/anypb"
> > +                                  "types/known/timestamppb"
> > +                                  "types/known/durationpb"
> > +                                  "types/known/wrapperspb"
> > +                                  "types/known/structpb"
> > +                                  "types/known/fieldmaskpb"
> > +                                  "types/known/apipb"
> > +                                  "types/known/typepb"
> > +                                  "types/known/sourcecontextpb"
> > +                                  "types/known/emptypb"
> > +                                  "types/descriptorpb"
> > +                                  "types/pluginpb"
> > +                                  "compiler/protogen"
> > +                                  "cmd/protoc-gen-go")))
> > +               (modify-phases %standard-phases
> > +                 (replace 'build
> > +                   (lambda* (#:key import-path build-flags #:allow-other-keys)
> > +                     (for-each
> > +                      (lambda (pkg)
> > +                        ((assoc-ref %standard-phases 'build)
> > +                         #:import-path (format #f "~a/~a" import-path pkg)
> > +                         #:build-flags build-flags))
> > +                      go-packages)))
> > +                 (replace 'check
> > +                   (lambda* (#:key tests? import-path #:allow-other-keys)
> > +                     (for-each
> > +                      (lambda (pkg)
> > +                        ((assoc-ref %standard-phases 'check)
> > +                         #:tests? tests?
> > +                         #:import-path (format #f "~a/~a" import-path pkg)))
> > +                      go-packages)))))))
>
> Is this a workaround for our lack of Go modules support?  An explanatory
> comment is needed.


Yes, I'll add the comment and send V2, thank you!