all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 66692@debbugs.gnu.org
Subject: bug#66692: [cuirass] Spurious failed builds following patching u-boot sources
Date: Sat, 28 Oct 2023 11:55:38 +0200	[thread overview]
Message-ID: <874jib9ilh.fsf@gnu.org> (raw)
In-Reply-To: <87pm15dpxn.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 23 Oct 2023 22:49:56 +0200")

Hi,

Ludovic Courtès <ludo@gnu.org> skribis:

>   2. All the ongoing and about-to-be-started builds carried out by
>      worker processes at that point were marked as failed.

This part of the problem was a bit more subtle.q

When ‘cuirass remote-server’ goes away, ‘cuirass remote-worker’ keeps
going if it was building something.  In that case the build log will be
lost (because the direct connection to the server was cut), but the
worker eventually notifies the server of build success/failure (ZeroMQ,
makes sure those messages are eventually sent, when the server is back).

The bug was that the worker could in some cases, when the server is
down, send a “build failed” message even though the bug had not
completed.

This is fixed by these Cuirass commits:

  2eb3e13 * remote-worker: Discard log anytime ‘send-log’ throws.
  4cc37f5 * remote-worker: Ignore the return value of ‘build-derivations&’.
  3bbb5c8 * store: ‘build-derivations&’ enforces synchronization with the build.

(I have yet to update the ‘cuirass’ package and to deploy it on ci.guix.
It’s been running for a few days at <https://guix.bordeaux.inria.fr>.)

Ludo’.




  parent reply	other threads:[~2023-10-28  9:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23  2:57 bug#66692: [cuirass] Spurious failed builds following patching u-boot sources Maxim Cournoyer
2023-10-23 20:49 ` Ludovic Courtès
2023-10-23 21:14   ` Ludovic Courtès
2023-10-24  0:59     ` Maxim Cournoyer
2023-10-24 20:27       ` Ludovic Courtès
2023-10-28  9:55   ` Ludovic Courtès [this message]
2023-10-30 13:13     ` Ludovic Courtès
     [not found] ` <handler.66692.D66692.169867163715469.notifdone@debbugs.gnu.org>
2023-10-31 13:31   ` bug#66692: closed (Re: bug#66692: [cuirass] Spurious failed builds following patching u-boot sources) Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jib9ilh.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=66692@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.