all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Hogan <code@greghogan.com>
Cc: 68829-done@debbugs.gnu.org
Subject: bug#68829: [PATCH 3/3] gnu: Add git-sizer.
Date: Sun, 18 Feb 2024 16:09:28 +0100	[thread overview]
Message-ID: <874je5n713.fsf@gnu.org> (raw)
In-Reply-To: <ba86d4c5c7758c78df4667b3bb3163f5b25e2e5e.1706645122.git.code@greghogan.com> (Greg Hogan's message of "Tue, 30 Jan 2024 20:08:06 +0000")

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

Hi,

Greg Hogan <code@greghogan.com> skribis:

> * gnu/packages/version-control.scm (git-sizer): New variable.
>
> Change-Id: I82a61e364782dabfd59d0e81ff310fa916b5ff23

Applied with the change below (suggested by ‘guix lint’).

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1367 bytes --]

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index ee6cd78107..afef900bbb 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -4028,12 +4028,14 @@ (define-public git-sizer
                 (string-append (assoc-ref outputs "out")
                                "/bin/git-sizer")))))
          (replace 'check
-           (lambda* (#:key import-path #:allow-other-keys)
-             (for-each (lambda (test)
-                         (invoke "go" "test" "-v" "-run" test import-path))
-                       ;; TestExec and TestSubmodule require a copy of the Git repository.
-                       '("TestBomb" "TestFromSubdir" "TestRefgroups"
-                         "TestRefSelections" "TestTaggedTags")))))))
+           (lambda* (#:key tests? import-path #:allow-other-keys)
+             (when tests?
+               (for-each (lambda (test)
+                           (invoke "go" "test" "-v" "-run" test import-path))
+                         ;; TestExec and TestSubmodule require a copy of the
+                         ;; Git repository.
+                         '("TestBomb" "TestFromSubdir" "TestRefgroups"
+                           "TestRefSelections" "TestTaggedTags"))))))))
     (native-inputs (list git))
     (propagated-inputs
      (list go-github-com-cli-safeexec

      reply	other threads:[~2024-02-18 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1706645122.git.code@greghogan.com>
2024-01-30 20:08 ` [bug#68829] [PATCH 1/3] gnu: Add go-github-com-cli-safeexec Greg Hogan
2024-01-30 20:08 ` [bug#68829] [PATCH 2/3] gnu: Add go-go-uber-org-goleak Greg Hogan
2024-01-30 20:08 ` [bug#68829] [PATCH 3/3] gnu: Add git-sizer Greg Hogan
2024-02-18 15:09   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874je5n713.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=68829-done@debbugs.gnu.org \
    --cc=code@greghogan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.