Re: 01/02: gnu: qemu: Update to 2.9.0 [security fixes].

[Mark H Weaver <mhw@netris.org>]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Apr 20, 2017 at 09:06:51PM -0400, Mark H Weaver wrote:
>> leo@famulari.name (Leo Famulari) writes:
>> >     gnu: qemu: Update to 2.9.0 [security fixes].
>> 
>> Thanks for this!  Obviously it's an important security update, but:
>> 
>> On my x86_64 system running GuixSD, 'grub' now fails to build from
>> source.  Three times in a row, the 'grub_cmd_set_date' has failed.
>> Here's the relevant excerpt from test-suite.log (lightly formatted):
>> 
>>   FAIL: grub_cmd_set_date
>>   =======================
>
>> Has anyone else seen this?
>
> I just ran the build 5 times on my x86_64 machine, and it failed this
> test 1/5 times.
>
> We could try patching the test file with 'set -x' to trace the execution
> of the script and see exactly what goes wrong.

Of course it would be good to investigate, but for now, here is the
patch that I used to disable that one test.

       Mark



[-- Attachment #2: [PATCH] DRAFT: gnu: grub: Disable failing test --]
[-- Type: text/x-patch, Size: 1598 bytes --]

From 3ea154ed0dff96c348a0ee5a3a45678fc8a1dfb5 Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Thu, 20 Apr 2017 21:14:45 -0400
Subject: [PATCH] DRAFT: gnu: grub: Disable failing test.

* gnu/packages/bootloaders.scm (grub)[arguments]: Add 'disable-failing-test'
phase.
---
 gnu/packages/bootloaders.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 98afc6a7c..f495c39d7 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès <ludo@gnu.org>
-;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2015, 2017 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2016, 2017 Marius Bakke <mbakke@fastmail.com>
@@ -95,7 +95,12 @@
                      ;; Make the font visible.
                      (copy-file (assoc-ref inputs "unifont") "unifont.bdf.gz")
                      (system* "gunzip" "unifont.bdf.gz")
-                     #t)))))
+                     #t))
+                  (add-before 'check 'disable-failing-test
+                    (lambda _
+                      (substitute* "Makefile"
+                        ((" grub_cmd_set_date ") " "))
+                      #t)))))
     (inputs
      `(("gettext" ,gettext-minimal)
 
-- 
2.12.2