From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: 27893@debbugs.gnu.org
Subject: [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2.
Date: Tue, 01 Aug 2017 11:46:44 +0200 [thread overview]
Message-ID: <87379bsjqz.fsf@gnu.org> (raw)
In-Reply-To: <3460381662f16e6d267a21c7d2f83a9cea216b6e.1501546450.git.leo@famulari.name> (Leo Famulari's message of "Mon, 31 Jul 2017 20:14:10 -0400")
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
Hi Leo,
Leo Famulari <leo@famulari.name> skribis:
> * gnu/packages/version-control.scm (libgit2-0.25): New variable.
> * gnu/packages/julia.scm (julia)[inputs]: Replace LIBGIT2 with LIBGIT2-0.25.
> * gnu/packages/patches/libgit2-use-after-free.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
Sorry for not noticing the breakage! I wonder if it would be
easier/safer to fix Julia than to keep the old libgit2.
Does this upstream commit fix the failures that you saw?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 908 bytes --]
commit 782460f9bab4af35097c13c4dbab61cb263490b9
Author: Milan Bouchet-Valat <nalimilan@club.fr>
Date: Tue Jul 11 10:02:32 2017 +0200
Fix libgit2 test failure with system libgit2 and OpenSSL (#22722)
The first letter of the error message is in lowercase in some systems,
notably Fedora Rawhide with libgit2 0.26 and OpenSSL 1.1.0f.
diff --git a/test/libgit2.jl b/test/libgit2.jl
index d7e32d21a9..f5104e9ec7 100644
--- a/test/libgit2.jl
+++ b/test/libgit2.jl
@@ -1905,7 +1905,8 @@ mktempdir() do dir
deserialize(f)
end
@test err.code == LibGit2.Error.ECERTIFICATE
- @test startswith(err.msg, "The SSL certificate is invalid")
+ @test startswith(lowercase(err.msg),
+ lowercase("The SSL certificate is invalid"))
rm(errfile)
[-- Attachment #3: Type: text/plain, Size: 12 bytes --]
Ludo’.
next prev parent reply other threads:[~2017-08-01 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 0:14 [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2 Leo Famulari
2017-08-01 9:46 ` Ludovic Courtès [this message]
2017-08-01 20:31 ` Leo Famulari
2017-10-18 21:15 ` Ricardo Wurmus
2018-03-07 14:03 ` bug#27893: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87379bsjqz.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27893@debbugs.gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.