From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30702@debbugs.gnu.org
Subject: [bug#30702] [PATCH] services: nginx: Support extra content in the http block.
Date: Mon, 11 Jun 2018 19:09:39 +0100 [thread overview]
Message-ID: <8736xt42l8.fsf@cbaines.net> (raw)
In-Reply-To: <87wovzo01h.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hello,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> This helpful when adding content to the nginx configuration file, which isn't
>> supported by the record type used for the configuration. For example, like
>> adding proxy_cache_path configuration.
>>
>> * gnu/packages/web.scm (<nginx-configuration>): Add new extra-content field.
>> (nginx-configuration-extra-content): New field accessor.
>> (default-nginx-config): Add support for the extra-content field.
>> * doc/guix.texi (NGINX): Document the new extra-content field.
>
> [...]
>
>> +@item @code{extra-content} (default: @code{""})
>> +Extra content for the @code{http} block. Should be string or a string
>> +valued G-expression.
>
> [...]
>
>> (apply mixed-text-file "nginx.conf"
>> (flatten
>> "user nginx nginx;\n"
>> @@ -542,7 +546,8 @@ of index files."
>> "\n"
>> (map emit-nginx-upstream-config upstream-blocks)
>> (map emit-nginx-server-config server-blocks)
>> - "}\n"
>> + extra-content
>> + "\n}\n"
>> "events {}\n"))))
>
> That doesn’t work if ‘extra-content’ is something like:
>
> #~(string-append "foo" bar)
>
> does it?
>
> My understanding of the doc above was that it intends to allow this.
> But maybe it doesn’t matter after all?
So... I've finally got back around to looking at this, and as far as I
can see, it does work. extra-content is passed as one of the arguments
to mixed-text-file, which accepts G-exp things.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2018-06-11 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 20:00 [bug#30702] [PATCH] services: nginx: Support extra content in the http block Christopher Baines
2018-03-17 21:42 ` Ludovic Courtès
2018-03-17 23:46 ` Christopher Baines
2018-03-18 17:12 ` Ludovic Courtès
2018-05-18 8:54 ` Christopher Baines
2018-05-19 20:36 ` Ludovic Courtès
2018-06-11 18:09 ` Christopher Baines [this message]
2018-06-12 9:09 ` Ludovic Courtès
2018-06-12 20:22 ` bug#30702: " Christopher Baines
2018-05-18 9:37 ` [bug#30702] " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736xt42l8.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=30702@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.