From: "Ludovic Courtès" <ludo@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 34040@debbugs.gnu.org
Subject: [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating.
Date: Sat, 12 Jan 2019 14:40:47 +0100 [thread overview]
Message-ID: <8736py6lk0.fsf@gnu.org> (raw)
In-Reply-To: <20190111094208.28327-1-rekado@elephly.net> (Ricardo Wurmus's message of "Fri, 11 Jan 2019 10:42:07 +0100")
Hello,
Ricardo Wurmus <rekado@elephly.net> skribis:
> * guix/upstream.scm (<upstream-source>)[input-changes]: New field.
> (<upstream-input-change>): New record.
> (upstream-input-change?, upstream-input-change-name,
> upstream-input-change-type, upstream-input-change-action, changed-inputs): New
> procedures.
> (package-update): Pass along input changes.
> * guix/script/refresh.scm (update-package): Process input changes.
Really cool!
> +;; Representation of an upstream input change.
> +(define-record-type* <upstream-input-change>
> + upstream-input-change make-upstream-input-change
> + upstream-input-change?
> + (name upstream-input-change-name) ;string
> + (type upstream-input-change-type) ;symbol: regular | native | propagated
> + (action upstream-input-change-action)) ;symbol: add | remove
Perhaps in some cases in action could be, say, (upgrade "1.2"). Though
that’s of course something we can add later.
> (define* (package-update store package updaters
> #:key (key-download 'interactive))
> - "Return the new version and the file name of the new version tarball for
> -PACKAGE, or #f and #f when PACKAGE is up-to-date. KEY-DOWNLOAD specifies a
> -download policy for missing OpenPGP keys; allowed values: 'always', 'never',
> -and 'interactive' (default)."
> + "Return the new version, the file name of the new version tarball and input
^
Missing comma. :-)
> +changes for PACKAGE, or #f and #f when PACKAGE is up-to-date. KEY-DOWNLOAD
^
Instead of “, or …”:
; return #f (three values) when PACKAGE is up-to-date.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2019-01-12 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 9:11 [bug#34040] Suggest input changes when updating packages Ricardo Wurmus
2019-01-11 9:42 ` [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating Ricardo Wurmus
2019-01-11 9:42 ` [bug#34040] [PATCH 2/2] import: cran: Suggest input changes Ricardo Wurmus
2019-01-12 13:42 ` Ludovic Courtès
2019-01-12 21:11 ` Ricardo Wurmus
2019-01-12 13:40 ` Ludovic Courtès [this message]
2019-01-21 21:34 ` [bug#34040] [PATCH 1/2] refresh: Suggest input changes when updating Ludovic Courtès
2019-01-25 16:21 ` Ricardo Wurmus
2019-01-25 21:15 ` Ludovic Courtès
2019-01-25 21:48 ` Ricardo Wurmus
2019-01-26 13:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736py6lk0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34040@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.