From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 33497-done@debbugs.gnu.org
Subject: bug#33497: [PATCHv2] Re: bug#33497: Our CMake package has no documentation
Date: Thu, 21 Mar 2019 22:19:29 -0400 [thread overview]
Message-ID: <8736nfps5q.fsf@gmail.com> (raw)
In-Reply-To: <87bm24840g.fsf@fastmail.com> (Marius Bakke's message of "Thu, 21 Mar 2019 19:40:47 +0100")
Marius Bakke <mbakke@fastmail.com> writes:
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Here's an improved version, following some comments of Marius on #guix.
>>
>> From 2f33a7321e5e37d37f57c229c8079cb4ffd10834 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Wed, 20 Mar 2019 21:38:19 -0400
>> Subject: [PATCH] cmake: Generate documentation.
>>
>> To prevent complicating the dependencies of a core tool, a new variant,
>> CMAKE-MINIMAL is introduced and the CMake build system is configured to use it
>> by default. The regular CMAKE package gains a manpage, info manual as well
>> as HTML documentation.
>>
>> Fixes issue #33497 (https://bugs.gnu.org/33497).
>>
>> * gnu/packages/cmake.scm (gnu): Use modules (gnu packages python-xyz),
>> (gnu packages texinfo) and (srfi srfi-1).
>> (cmake-minimal): Rename the original cmake variable to this.
>> [phases]{configure}: Extract the configure script arguments to...
>> [configure-flags]: here.
>> [properties]: Set the HIDDEN? property to #t.
>> (cmake): New variable, which inherits from CMAKE-MINIMAL.
>> [phases]{move-html-doc}: Add phase.
>> [native-inputs]: Add PYTHON-SPHINX and TEXINFO.
>> [outputs]: Add the "doc" output.
>> [properties]: Clear the inherited HIDDEN? property.
>> * guix/build-system/cmake.scm (default-cmake): Use CMAKE-MINIMAL instead of
>> CMAKE.
>
> Thanks! LGTM.
Pushed to core-updates with commit 2f33a7321e. Thank you!
Maxim
prev parent reply other threads:[~2019-03-22 2:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 6:49 bug#33497: Our CMake package has no documentation Maxim Cournoyer
2018-11-25 6:54 ` bug#33497: [PATCH] " Maxim Cournoyer
2019-02-12 20:17 ` Marius Bakke
2019-03-12 1:33 ` Maxim Cournoyer
2019-03-17 16:36 ` Marius Bakke
2019-03-20 16:06 ` Maxim Cournoyer
2019-03-21 2:08 ` bug#33497: [PATCHv2] " Maxim Cournoyer
2019-03-21 18:40 ` Marius Bakke
2019-03-22 2:19 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736nfps5q.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=33497-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.