From: Ricardo Wurmus <rekado@elephly.net>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 37988@debbugs.gnu.org
Subject: [bug#37988] [PATCH 3/6] gnu: Add r-rprotobuflib.
Date: Wed, 30 Oct 2019 12:39:12 +0100 [thread overview]
Message-ID: <8736fah38i.fsf@elephly.net> (raw)
In-Reply-To: <20191030102531.12495-3-zimon.toutoune@gmail.com>
Hi,
thank you for the patches!
> * gnu/packages/bioconductor.scm (r-rprotobuflib): New variable.
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + ;; Contains unverified binaries:
> + ;; src/win/lib/{i386,x64}/libprotobuf.a
> + (add-after 'unpack 'remove-win-folder
> + (lambda _
> + (delete-file-recursively "src/win")
> + #t))
This should be done in a snippet instead.
> + ;; Fix non-conventional packaging.
> + ;; The dependency to protobuf-2.6.0 is included as tgz and build
> + ;; by the R package itself.
> + (add-after 'unpack 'fix-wrong-hard-coded
> + (lambda _
> + (with-directory-excursion "src"
> + (invoke "tar" "xf" "protobuf-2.6.0.tgz"))
> + (substitute* "src/protobuf-2.6.0/configure"
> + (("#! /bin/sh") (string-append "#!" (which "sh"))))
> + #t)))))
Can we just use our protobuf package instead of using the bundled sources?
> + (description "This package provides the headers and static library of
> +Protocol buffers 2.6.0 for other R packages to compile and link
> against.")
I would prefer not to mention the specific version here.
--
Ricardo
next prev parent reply other threads:[~2019-10-30 11:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 10:23 [bug#37988] [PATCH 0/6] Add flowWorkspace from BioConductor zimoun
2019-10-30 10:25 ` [bug#37988] [PATCH 1/6] gnu: Add r-idpmisc zimoun
2019-10-30 10:25 ` [bug#37988] [PATCH 2/6] gnu: Add r-flowviz zimoun
2019-10-30 10:25 ` [bug#37988] [PATCH 3/6] gnu: Add r-rprotobuflib zimoun
2019-10-30 11:39 ` Ricardo Wurmus [this message]
2019-10-30 13:29 ` zimoun
2019-11-05 17:49 ` [bug#37988] [PATCH v2 " zimoun
2019-11-05 18:19 ` [bug#37988] [PATCH v3 " zimoun
2019-11-05 18:29 ` [bug#37988] [PATCH v4 " zimoun
2019-10-30 10:25 ` [bug#37988] [PATCH 4/6] gnu: Add r-cytolib zimoun
2019-10-30 11:41 ` Ricardo Wurmus
2019-10-30 12:42 ` [bug#37988] [PATCH v2 " zimoun
2019-10-30 10:25 ` [bug#37988] [PATCH 5/6] gnu: Add r-ncdfflow zimoun
2019-10-30 11:42 ` Ricardo Wurmus
2019-10-30 10:25 ` [bug#37988] [PATCH 6/6] gnu: Add r-flowworkspace zimoun
2020-02-21 16:39 ` [bug#37988] why? zimoun
2020-02-21 18:38 ` Ricardo Wurmus
2020-02-21 19:12 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736fah38i.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=37988@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.