From: Xinglu Chen <public@yoctocell.xyz>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 49101@debbugs.gnu.org
Subject: [bug#49101] [PATCH 0/4] Add ocaml-mparser & friends
Date: Sat, 19 Jun 2021 10:35:25 +0200 [thread overview]
Message-ID: <8735te45gy.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210619002851.732e3f59@tachikoma.lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 2487 bytes --]
On Sat, Jun 19 2021, Julien Lepiller wrote:
> Le Fri, 18 Jun 2021 21:00:51 +0200,
> Xinglu Chen <public@yoctocell.xyz> a écrit :
>
>> This series adds ‘ocaml-mparser’, a monad parser combinator library,
>> plus two extensions for it --- ‘ocaml-mparser-re’ and
>> ‘ocaml-mparser-pcre’.
>>
>> I noticed that there already exists an ‘ocaml4.07-pcre’ package, what
>> is the policy regarding ‘ocaml4.07-*’ and ‘ocaml-*’ packages?
>>
>> Xinglu Chen (4):
>> gnu: Add ocaml-mparser.
>> gnu: Add ocaml-mparser-re.
>> gnu: Add ocaml-mparser-pcre.
>> gnu: Add ocaml-pcre.
>>
>> gnu/packages/ocaml.scm | 88
>> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 88
>> insertions(+)
>>
>>
>> base-commit: caf4a7a2770ef4d05a6e18f40d602e51da749ddc
>
> Hi Xinglu,
>
> thank you for the patches! First, you should reorder your patches: we
> try to make sure every revision of guix is correct, but after the third
> patch, ocaml-pcre is missing. I would simply put pcre first :).
Yeah, I think I messed something up when sending them.
> To answer your question, we try to avoid having both the ocaml and
> ocaml4.07 around if possible. It seems that ocaml4.07-pcre is only
> required for ocaml4.07-expect. Could you check if it is possible to
> build expect with our latest ocaml package?
>
> If so, please have a patch that builds pcre and expect with the latest
> ocaml, then another patch for updating pcre to the latest version, then
> your three patches to add mparser.
>
> If not, then we have to keep ocaml4.07-pcre around, so here is how we
> do it, in a single patch:
>
> Replace ocaml4.07-pcre with ocaml-pcre (remove the arguments that use
> ocaml-4.07) and create a new ocaml4.07-pcre that inherits from it. It
> would look like this:
>
> (define-public ocaml-pcre
> (package
> (name "ocaml-pcre")
> ...
> (properties `((ocaml4.07-variant ,(delay ocaml4.07-pcre))))
> ...))
>
> (define-public ocaml4.07-pcre
> (package-with-ocaml4.07
> (package
> (inherit ocaml-pcre)
> ...
> (properties '()))))
>
> If the latest version of pcre cannot be built with ocaml 4.07, you can
> specify a different source, like we do for ocaml4.07-parsexp for
> instance.
Thanks for the detailed answer! I think it would be great to have
something like this in the manual :)
> I'm looking forward to v2 of this series :)
Should be coming soon :)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-06-19 8:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 19:00 [bug#49101] [PATCH 0/4] Add ocaml-mparser & friends Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 1/4] gnu: Add ocaml-mparser Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 3/4] gnu: Add ocaml-mparser-pcre Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 4/4] gnu: Add ocaml-pcre Xinglu Chen
2021-06-18 19:03 ` [bug#49101] [PATCH 2/4] gnu: Add ocaml-mparser-re Xinglu Chen
2021-06-18 22:28 ` [bug#49101] [PATCH 0/4] Add ocaml-mparser & friends Julien Lepiller
2021-06-19 8:35 ` Xinglu Chen [this message]
2021-06-19 9:03 ` [bug#49101] [PATCH v2 0/5] Add ocaml-mparser & firends Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 1/5] gnu: ocaml4.07-pcre: Switch to default OCaml compiler Xinglu Chen
2021-06-19 11:01 ` Julien Lepiller
2021-06-19 13:51 ` Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 2/5] gnu: ocaml4.07-expect: " Xinglu Chen
2021-06-19 11:05 ` Julien Lepiller
2021-06-19 13:57 ` Xinglu Chen
2021-06-19 14:06 ` Xinglu Chen
2021-06-19 15:09 ` Julien Lepiller
2021-06-19 9:03 ` [bug#49101] [PATCH v2 3/5] gnu: Add ocaml-mparser Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 4/5] gnu: Add ocaml-mparser-re Xinglu Chen
2021-06-19 9:03 ` [bug#49101] [PATCH v2 5/5] gnu: Add ocaml-mparser-pcre Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 0/6] Add ocaml-mparser & friends Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 1/6] gnu: Add ocaml-pcre Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 2/6] gnu: ocaml4.07-expect: Switch to default OCaml compiler Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 3/6] gnu: ocaml4.07-pcre: Remove package Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 4/6] gnu: Add ocaml-mparser Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 5/6] gnu: Add ocaml-mparser-re Xinglu Chen
2021-06-19 15:50 ` [bug#49101] [PATCH v3 6/6] gnu: Add ocaml-mparser-pcre Xinglu Chen
2021-06-20 0:16 ` bug#49101: [PATCH v3 0/6] Add ocaml-mparser & friends Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735te45gy.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=49101@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.