From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: raingloom <raingloom@riseup.net>
Cc: 50393@debbugs.gnu.org
Subject: [bug#50393] [PATCH] gnu: Add wlsunset.
Date: Mon, 06 Sep 2021 11:08:59 +0200 [thread overview]
Message-ID: <8735qicbpw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210905071150.50526fd4@riseup.net> (raingloom@riseup.net's message of "Sun, 5 Sep 2021 07:11:50 +0200")
Hello,
raingloom <raingloom@riseup.net> writes:
> +(define-public wlsunset
Thank you. Some nits follow.
> + (package
> + (name "wlsunset")
> + (version "0.2.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.sr.ht/~kennylevinsen/wlsunset/")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0hhsddh3rs066rbsjksr8kcwg8lvglbvs67dq0r5wx5c1xcwb51w"))))
> + (build-system meson-build-system)
> + (inputs
> + `(("wayland-protocols" ,wayland-protocols)
> + ("wayland" ,wayland)))
Could you order inputs alphabetically?
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (synopsis "Day/night gamma adjustments for Wayland compositors")
> + (home-page "https://sr.ht/~kennylevinsen/wlsunset/")
> + (description
> + "Day/night gamma adjustments for Wayland compositors supporting
> +wlr-gamma-control-unstable-v1. Also known as a blue light filter or
> night +light.")
Could you use complete sentences for the description? I suggest using
markup: @samp{wlr-gamma-control-unstable-v1}.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-09-06 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 5:11 [bug#50393] [PATCH] gnu: Add wlsunset raingloom
2021-09-06 9:08 ` Nicolas Goaziou [this message]
[not found] ` <20210914174633.41cac33c@riseup.net>
2021-09-15 19:28 ` bug#50393: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735qicbpw.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=50393@debbugs.gnu.org \
--cc=raingloom@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.