all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: Arun Isaac <arunisaac@systemreboot.net>,
	Leo Prikler <leo.prikler@student.tugraz.at>,
	48237@debbugs.gnu.org
Subject: [bug#48237] [PATCH] gnu: emacs-consult: Add ‘emacs-ve
Date: Mon, 06 Sep 2021 13:51:24 -0400	[thread overview]
Message-ID: <8735qhbnj7.fsf@gmail.com> (raw)
In-Reply-To: <87v93d24tx.fsf@yoctocell.xyz> (Xinglu Chen's message of "Mon, 06 Sep 2021 15:47:54 +0200")

Hello Arun,

Xinglu Chen <public@yoctocell.xyz> writes:

> On Wed, Aug 11 2021, Arun Isaac wrote:
>
>> Hi all,
>>
>> I actually think we should not add emacs-vertico to the
>> propagated-inputs, and remove emacs-flycheck and emacs-selectrum as
>> well. All these are optional dependencies, and we should leave it to the
>> user to install the ones they want. At least in this specific case, the
>> three packages (flycheck, selectrum and vertico) are the kind the user
>> would want to explicitly install. They aren't backend libraries that
>> ought to remain invisible to the user.
>>
>> In fact, this is the version of emacs-consult I have installed in my
>> profile.

Guix packages typically come as featureful as possible unless there are
good reasons not too (to minimize the closure size, for example).  In
this case, the added optional dependencies seem to have negligible
effect on the closure size, according to `guix size`; I'd be in favor to
keep the optional dependencies specified for that reason, unless there
are other considerations that I'm missing.

> Another option would be to define package variants of ‘emacs-consult’,
> that way we would have four packages:
>
> * emacs-consult;
> * emacs-consult-flycheck;
> * emacs-consult-vertico; and
> * emacs-consult.

I would prefer not go that route (variants multiplication), especially
when the user already has a way to customize.

My 2 cents,

Maxim




  reply	other threads:[~2021-09-06 17:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 13:26 [bug#48237] [PATCH] gnu: emacs-consult: Add ‘emacs-ve Xinglu Chen
2021-05-05 17:39 ` Leo Prikler
2021-05-07 14:23   ` Xinglu Chen
2021-06-02 15:32     ` Xinglu Chen
2021-08-11 15:23       ` Arun Isaac
2021-09-06 13:47         ` Xinglu Chen
2021-09-06 17:51           ` Maxim Cournoyer [this message]
2021-09-06 18:05             ` Liliana Marie Prikler
2021-09-06 20:34               ` Arun Isaac
2021-09-06 23:18                 ` Maxim Cournoyer
2021-09-06 23:17               ` Maxim Cournoyer
2021-09-07  7:05                 ` Liliana Marie Prikler
2021-09-07 17:49               ` Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735qhbnj7.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=48237@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=leo.prikler@student.tugraz.at \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.