[bug#45130] [PATCH] gnu: Add mtm.

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

phodina via Guix-patches via <guix-patches@gnu.org> writes:

> here's updated version of the patch where the version uses newest tag
> instead of commit. Otherwise LGTM.

Is there any reason to put the variable in suckless.scm?

> +         (replace 'install
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out")))
> +               ;; install binary
> +               (mkdir-p (string-append out "bin/"))
> +               (install-file "mtm" (string-append out "/bin"))
> +               ;; install manpage
> +               (mkdir-p (string-append out "share/man/man1"))
> +               (install-file "mtm.1" (string-append out "/share/man/man1"))
> +               ;; install terminfo
> +               (mkdir-p (string-append out "share/terminfo"))
> +               (invoke (string-append (assoc-ref inputs "ncurses") "/bin/tic")
> +                       "-x" "-s" "-o"
> +                       (string-append
> +                        out "/share/terminfo")
> +                       "mtm.ti"))
> +             #t))

We can remove the trailing #t.

> +         (delete 'configure))))

There's probably a missing comment "no configure script"

> +    ;; FIXME: This should only be located in 'ncurses'.  Nonetheless it is
> +    ;; provided for usability reasons.  See <https://bugs.gnu.org/22138>.
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "TERMINFO_DIRS")
> +            (files '("share/terminfo")))))
> +    (synopsis "Micro Terminal Multiplexer")
> +    (description
> +     "This package provides multiplexer for the terminal focused on simplicity,
> +compatibility, size and stability.")
> +    (license license:gpl3+)
> +    (home-page "https://github.com/deadpixi/mtm")))

Nitpick: the home-page field is usually above the synopsis.

Regards,
-- 
Nicolas Goaziou