From: Andrew Tropin <andrew@trop.in>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 53812@debbugs.gnu.org, Protesilaos Stavrou <public@protesilaos.com>
Subject: [bug#53812] [PATCH] gnu: Add emacs-mct.
Date: Mon, 07 Feb 2022 18:04:26 +0300 [thread overview]
Message-ID: <8735ku90qt.fsf@trop.in> (raw)
In-Reply-To: <878runhden.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 1738 bytes --]
On 2022-02-06 22:51, Nicolas Goaziou wrote:
> Hello,
>
> Andrew Tropin <andrew@trop.in> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-mct): New variable.
>
> Thank you.
>
>> +(define-public emacs-mct
>> + (package
>> + (name "emacs-mct")
>> + (version "0.4.2")
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://gitlab.com/protesilaos/mct.git")
>> + (commit version)))
>> + (sha256
>> + (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
>> + (file-name (git-file-name name version))))
>> + (build-system emacs-build-system)
>> + (license license:gpl3+)
>> + (home-page "https://protesilaos.com/emacs/mct")
>> + (synopsis "Enhancement of the default Emacs minibuffer completion UI.")
>
> Synopsis may not end with a period. You may want to run "guix lint" on
> your package definition.
>
>> + (description "Minibuffer and Completions in Tandem, also known as
>> +mct, or mct.el, is a package that enhances the default minibuffer and
>> +*Completions* buffer of Emacs 27 (or higher) so that they work
>> +together as part of a unified framework. The idea is to make the
>> +presentation and overall functionality be consistent with other
>> +popular, vertically aligned completion UIs while leveraging built-in
>> +functionality.")))
>
> Sentences in description should be separated with two spaces.
>
> Nitpick: license field usually comes last.
>
> Note that upstream mentions this is an Emacs 28+ package, and Guix
> provides only Emacs 27.2. Would it be a bit early to provide this
> package?
>
> Regards,
Attaching v2, seems all the issues and questions are addressed.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: v2-0001-gnu-Add-emacs-mct.patch --]
[-- Type: text/x-patch, Size: 1810 bytes --]
From b4878a8adcbae7dd988df4741a39b0e0c27fb92b Mon Sep 17 00:00:00 2001
From: Andrew Tropin <andrew@trop.in>
Date: Sat, 5 Feb 2022 20:19:52 +0300
Subject: [PATCH v2] gnu: Add emacs-mct.
* gnu/packages/emacs-xyz.scm (emacs-mct): New variable.
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 444b761116..d7faf6ea6f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30090,3 +30090,26 @@ (define-public emacs-fennel-mode
"Fennel mode provides font-lock, indentation, navigation, and REPL for
Fennel code within Emacs.")
(license license:gpl3+)))
+
+(define-public emacs-mct
+ (package
+ (name "emacs-mct")
+ (version "0.4.2")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.com/protesilaos/mct.git")
+ (commit version)))
+ (sha256
+ (base32 "0sj9hyxpighspwrm2yimqkdxlhw2yiznaj69ysn2sjd6jn2aqpc6"))
+ (file-name (git-file-name name version))))
+ (build-system emacs-build-system)
+ (home-page "https://protesilaos.com/emacs/mct")
+ (synopsis "Enhancement of the default Emacs minibuffer completion UI")
+ (description "Minibuffer and Completions in Tandem, also known as mct, or
+mct.el, is a package that enhances the default minibuffer and *Completions*
+buffer of Emacs 27 (or higher) so that they work together as part of a unified
+framework. The idea is to make the presentation and overall functionality be
+consistent with other popular, vertically aligned completion UIs while
+leveraging built-in functionality.")
+ (license license:gpl3+)))
--
2.34.0
[-- Attachment #1.3: Type: text/plain, Size: 37 bytes --]
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]
next prev parent reply other threads:[~2022-02-07 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 17:19 [bug#53812] [PATCH] gnu: Add emacs-mct Andrew Tropin
2022-02-06 21:51 ` Nicolas Goaziou
2022-02-07 4:21 ` Protesilaos Stavrou
2022-02-07 15:04 ` Andrew Tropin [this message]
2022-02-08 0:11 ` bug#53812: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735ku90qt.fsf@trop.in \
--to=andrew@trop.in \
--cc=53812@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=public@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.