From: Christopher Baines <mail@cbaines.net>
To: Andreas Enge <andreas@enge.fr>
Cc: 61879@debbugs.gnu.org
Subject: bug#61879: Patch
Date: Fri, 14 Apr 2023 11:37:05 +0100 [thread overview]
Message-ID: <873552wxnb.fsf@cbaines.net> (raw)
In-Reply-To: <ZDkgIG/KpP6W6ual@jurong>
[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]
Andreas Enge <andreas@enge.fr> writes:
> Am Fri, Apr 14, 2023 at 09:20:03AM +0100 schrieb Christopher Baines:
>> I haven't tried this yet, but I've had a quick look. I'm not sure
>> search-patches will work where it is, since that'll be running in the
>> build environment, without any access to the patches in the Guix git
>> repository.
>
> Good point. But is this not exactly like your previous commit, which
> I understood you had tested? But you are right:
> https://ci.guix.gnu.org/build/909454/log/raw
> error: in phase 'patch-powerpc': uncaught exception:
> unbound-variable #f "Unbound variable: ~S" (search-patch) #f
> phase `patch-powerpc' failed after 0.0 seconds
> I will revert (the good news: it indeed did not break any other
> architecture).
>
> If we do not have access to the patch during build, we would need to
> replace it by an invocation of substitute*, with a lot of escaping of
> special characters like line ends, which would be annoying to test
> (well, one could test on x86_64 on a dummy package with the same source
> as gcc-11).
The changes I muddled together differed in that the search-patches bit
was ungexp'ed, so the patch file was handled through that mechanism. The
other important change is the actual patch itself differed as well (ec
needs moving up a bit).
I've made those changes to the commit you pushed earlier and pushed to
core-updates now.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2023-04-14 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 23:16 bug#61879: [core-updates] libstdc++ fails to build on powerpc64le-linux Ludovic Courtès
2023-04-13 9:32 ` Powerpc on core-updates Andreas Enge
2023-04-13 9:51 ` Andreas Enge
2023-04-13 13:46 ` bug#61879: " Christopher Baines
2023-04-13 14:06 ` Andreas Enge
2023-04-13 16:57 ` bug#61879: Patch Andreas Enge
2023-04-14 8:15 ` Andreas Enge
2023-04-14 8:20 ` Christopher Baines
2023-04-14 9:42 ` Andreas Enge
2023-04-14 10:37 ` Christopher Baines [this message]
2023-04-14 12:10 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873552wxnb.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=61879@debbugs.gnu.org \
--cc=andreas@enge.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.