From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 63330@debbugs.gnu.org
Subject: [bug#63330] [PATCH 0/4] Functional programming? In my C++?! It's more likely than you think!
Date: Sun, 07 May 2023 13:12:43 -0400 [thread overview]
Message-ID: <873548ysj8.fsf@gmail.com> (raw)
In-Reply-To: <1db1242ff474042bb007ace4ab4421f9061db2a6.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 07 May 2023 17:51:39 +0200")
Hi,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Sonntag, dem 07.05.2023 um 11:30 -0400 schrieb Maxim Cournoyer:
>> Hi,
>>
>> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>>
>> > * gnu/packages/cpp.scm (immer): New variable.
>> > ---
>> > gnu/packages/cpp.scm | 33 +++++++++++++++++++++++++++++++++
>> > 1 file changed, 33 insertions(+)
>> >
>> > diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
>> > index 023d1c0337..da3567b5ef 100644
>> > --- a/gnu/packages/cpp.scm
>> > +++ b/gnu/packages/cpp.scm
>> > @@ -67,6 +67,7 @@ (define-module (gnu packages cpp)
>> > #:use-module (gnu packages)
>> > #:use-module (gnu packages assembly)
>> > #:use-module (gnu packages autotools)
>> > + #:use-module (gnu packages bdw-gc)
>> > #:use-module (gnu packages boost)
>> > #:use-module (gnu packages build-tools)
>> > #:use-module (gnu packages c)
>> > @@ -1390,6 +1391,38 @@ (define-public libexpected
>> > (home-page "https://tl.tartanllama.xyz/")
>> > (license license:cc0)))
>> >
>> > +(define-public immer
>> > + (package
>> > + (name "immer")
>> > + (version "0.8.0")
>> > + (source (origin
>> > + (method git-fetch)
>> > + (uri (git-reference
>> > + (url "https://github.com/arximboldi/immer")
>> > + (commit (string-append "v" version))))
>> > + (file-name (git-file-name name version))
>> > + (sha256
>> > + (base32
>> > "11km3l5h3rgsbj8yfyzk3fnx9na55l6zs2sxpx922yvlvs2blh27"))
>> > + (modules '((guix build utils)))
>> > + (snippet #~(begin
>> > + (delete-file "tools/include/doctest.h")
>> > + (delete-file "tools/include/catch.hpp")
>> > + (substitute* (find-files "test"
>> > "\\.[cih]pp")
>> > + (("<catch.hpp>") "<catch2/catch.hpp>")
>> > + (("<doctest.h>")
>> > "<doctest/doctest.h>"))
>> > + (substitute* (find-files "test/oss-fuzz"
>> > "\\.cpp")
>> > + ;; someone used the wrong header :)
>> > + (("<fmt/printf.h>")
>> > "<fmt/ostream.h>"))))))
>>
>> Did you report the wrong header usage upstream?
> I must admit, I did not.
Could you please do so, if that's not too much to ask? Then include a
(see: URL) next to the substitution comment.
>> A less intrusive fix for the catch/doctest include problem could be
>> to add their include subdirectories as -I directives to the CXXFLAGS
>> environment variable, or since that's CMake, via its CMAKE_CXX_FLAGS
>> make options. See 'clara' for an actual example.
> There are other packages that take the approach I used here. I do
> think this is a CMakeFiles bug, but not one I want to fix.
I think catch2 is selfom used from the system (typically bundled), must
not ship with any pkg-config or proper support to be auto-detected at
configure time, which gives us the situation we're in.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-05-07 17:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 16:04 [bug#63330] [PATCH 0/4] Functional programming? In my C++?! It's more likely than you think! Liliana Marie Prikler
2023-05-06 13:41 ` [bug#63330] [PATCH 2/4] gnu: Add immer Liliana Marie Prikler
2023-05-07 15:30 ` [bug#63330] [PATCH 0/4] Functional programming? In my C++?! It's more likely than you think! Maxim Cournoyer
2023-05-07 15:51 ` Liliana Marie Prikler
2023-05-07 17:12 ` Maxim Cournoyer [this message]
2023-05-07 19:40 ` Liliana Marie Prikler
2023-05-06 13:43 ` [bug#63330] [PATCH 3/4] gnu: Add zug Liliana Marie Prikler
2023-05-07 15:25 ` [bug#63330] [PATCH 0/4] Functional programming? In my C++?! It's more likely than you think! Maxim Cournoyer
2023-05-06 13:43 ` [bug#63330] [PATCH 4/4] gnu: Add lager Liliana Marie Prikler
2023-05-07 15:34 ` [bug#63330] [PATCH 0/4] Functional programming? In my C++?! It's more likely than you think! Maxim Cournoyer
2023-05-07 15:57 ` Liliana Marie Prikler
2023-05-07 17:10 ` Maxim Cournoyer
2023-05-11 13:23 ` Simon Tournier
2023-05-14 10:31 ` bug#63330: " Liliana Marie Prikler
2023-05-06 13:51 ` [bug#63330] [PATCH 1/4] gnu: Add c-rrb Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873548ysj8.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=63330@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.